Skip to content

fix(iOS): reset zoomScale before contentOffset when recycling ScrollView #58932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aljadan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(iOS): reset zoomScale before contentOffset when recycling ScrollView #58932

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...eact-native/React/Fabric/Mounting/ComponentViews/ScrollView/RCTScrollViewComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,9 +692,11 @@ - (void)prepareForRecycle
_state.reset();

const auto &props = static_cast<const ScrollViewProps &>(*_props);
_scrollView.contentOffset = RCTCGPointFromPoint(props.contentOffset);
// Reset zoom scale to default
// Reset zoom scale to default. This must happen before resetting contentOffset:
// in RTL the mirroring transform makes UIKit report zoomScale == -1, and changing
// it to 1 makes UIKit move contentOffset.
_scrollView.zoomScale = 1.0;
_scrollView.contentOffset = RCTCGPointFromPoint(props.contentOffset);
// Invalidate cached content size so that updateState: recalculates the
// container frame after zoomScale reset (which may have mutated it in RTL).
_contentSize = CGSizeZero;
Expand Down
Loading