Skip to content

Keep RNTester content clear of the iOS tab bar #58933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cipolleschi wants to merge 5 commits into from
Closed

Keep RNTester content clear of the iOS tab bar #58933

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2440b5c
Skip android-release-only Maestro flows on iOS RNTester
cipolleschi Oct 7, 2026
1e63505
Save Maestro debug output for iOS E2E flows
cipolleschi Oct 7, 2026
a57e24c
Keep RNTester content clear of the iOS tab bar
cipolleschi Oct 7, 2026
239db25
Drop Maestro debug output change from this PR
cipolleschi Oct 7, 2026
0c9f94b
Use MAX for the bottom inset so it never drops below the tab bar
cipolleschi Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/rn-tester/RNTesterTabsIOS/ios/RNTesterTabsIOSComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,8 @@ - (void)tabSafeAreaInsetsDidChange:(UIEdgeInsets)insets
CGRectGetMaxY(tabBarFrame) >= CGRectGetMaxY(bounds);
if (hasBottomTabBar) {
insets.top = MAX(insets.top, LegacyTopInset);
insets.bottom = MIN(insets.bottom, LegacyBottomInset);
// Never go below the system inset: anything less leaves content under the tab bar, where taps switch tabs.
insets.bottom = MAX(insets.bottom, LegacyBottomInset);
} else {
insets.bottom = 0;
// A window with no status bar along the top, such as the iPhone Duo's, reports no top inset. Keep
Expand Down
Loading