Repository navigation
Conversation
Summary: Add the for-frameworks guard to the iOS `RCTTurboModuleManager.h`. `RCTTurboModuleManager` creates and owns TurboModules for a host, and `RCTTurboModuleManagerDelegate` is the protocol a host implements to supply them. That is host-integration API, in the same tier as `RCTHost.h` and `RCTInstance.h`, which are already for-frameworks: the app factory delegate in `RCTReactNativeFactory.h` adopts both `RCTHostDelegate` and `RCTTurboModuleManagerDelegate`, and imports both headers. Changelog: [Internal] Differential Revision: D124079995
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D124079995. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add the for-frameworks guard to the iOS
RCTTurboModuleManager.h.RCTTurboModuleManagercreates and owns TurboModules for a host, andRCTTurboModuleManagerDelegateis the protocol a host implements to supply them. That is host-integration API, in the same tier asRCTHost.handRCTInstance.h, which are already for-frameworks: the app factory delegate inRCTReactNativeFactory.hadopts bothRCTHostDelegateandRCTTurboModuleManagerDelegate, and imports both headers.Changelog: [Internal]
Differential Revision: D124079995