Repository navigation
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@vzaidman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D124083002. |
meta-codesync
Bot
changed the title
meta-codesync Bot
pushed a commit
that referenced
this pull request
Oct 8, 2026
Summary: Several headers were recently moved into the private or for-frameworks tier (cxxreact bundle header, TurboModule host integration, ModalHostView utils, platform-only ScrollView, animated internals, internal text components) without regenerating the C++ API snapshots, so `validate_cxx_api_snapshots` fails on every change. Regenerate all snapshots with `python -m scripts.cxx-api.parser` so the committed snapshots match the current header tiers. Changelog: [Internal] Reviewed By: coado Differential Revision: D124083002
meta-codesync
Bot
force-pushed
the
export-D124083002
branch
from
October 8, 2026 12:09
076c29a to
36dc64e
Compare
meta-codesync Bot
pushed a commit
that referenced
this pull request
Oct 8, 2026
Summary: Pull Request resolved: #58949 Several headers were recently moved into the private or for-frameworks tier (cxxreact bundle header, TurboModule host integration, ModalHostView utils, platform-only ScrollView, animated internals, internal text components) without regenerating the C++ API snapshots, so `validate_cxx_api_snapshots` fails on every change. Regenerate all snapshots with `python -m scripts.cxx-api.parser` so the committed snapshots match the current header tiers. Changelog: [Internal] Reviewed By: coado Differential Revision: D124083002
meta-codesync
Bot
force-pushed
the
export-D124083002
branch
from
October 8, 2026 12:13
36dc64e to
3f8ba19
Compare
meta-codesync Bot
pushed a commit
that referenced
this pull request
Oct 8, 2026
Summary: Several headers were recently moved into the private tier (platform-only ScrollView, animated internals, internal text components) without regenerating the C++ API snapshots, so `validate_cxx_api_snapshots` fails on every change. Regenerate all snapshots with `python -m scripts.cxx-api.parser` so the committed snapshots match the current header tiers. Changelog: [Internal] Reviewed By: coado Differential Revision: D124083002
meta-codesync
Bot
force-pushed
the
export-D124083002
branch
from
October 8, 2026 12:15
3f8ba19 to
9040218
Compare
Summary: Pull Request resolved: #58949 Several headers were recently moved into the private tier (platform-only ScrollView, animated internals, internal text components) without regenerating the C++ API snapshots, so `validate_cxx_api_snapshots` fails on every change. Regenerate all snapshots with `python -m scripts.cxx-api.parser` so the committed snapshots match the current header tiers. Changelog: [Internal] Reviewed By: coado Differential Revision: D124083002
meta-codesync
Bot
force-pushed
the
export-D124083002
branch
from
October 8, 2026 12:19
9040218 to
5a1e90e
Compare
|
This pull request has been merged in a4c421a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Several headers were recently moved into the private tier (platform-only ScrollView, animated internals, internal text components) without regenerating the C++ API snapshots, so
validate_cxx_api_snapshotsfails on every change.Regenerate all snapshots with
python -m scripts.cxx-api.parserso the committed snapshots match the current header tiers.Changelog: [Internal]
Reviewed By: coado
Differential Revision: D124083002