Repository navigation
Conversation
huntie
added this pull request to stack #58868
October 8, 2026 12:35
|
Caution Invalid Base Branch The base branch for this PR is |
huntie
force-pushed
the
pr58950
branch
2 times, most recently
from
October 8, 2026 13:52
19724ac to
4a82278
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
Continued review of built-in dev UI controls for iPhone Duo / wider screen devices.
Follows #58866.
Design changes
Redesign the "Paused in Debugger" overlay.
Notes
RCTDevLoadingViewmodule intoRCTDevBanner, a plain class in the same pod, which the module now owns. The paused overlay is anRCTPausedInDebuggerBannersubclass that overrides its hooks: window level, dimming, stack level, height, insets, the leading icon, the two-line text and the tap. The module's API is unchanged.RCTPausedInDebuggerOverlayControllerintoReact-CoreModulesso it can reachRCTDevBanner. Its only caller,RCTHost, already depends on that pod.Changelog:
[iOS][Changed] - Paused in debugger overlay: Redesign as a floating capsule
Test Plan
Debugger.pausefrom a scripted DevTools session shows the banner over the dimmed app, and tapping it sendsDebugger.resumedand hides it.Paused, iPhone 18 Pro
Edge case: Paused with the disconnected banner