Skip to content

Tweak LogBox notifications for iPhone Duo, fix rail touches - #58958

Closed
huntie wants to merge 1 commit into
mainfrom
pr58958
Closed

huntie wants to merge 1 commit into
mainfrom
pr58958

Conversation

@huntie

@huntie huntie commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Minimal fixes to the LogBox notification toasts for the iPhone Duo, where they stretch across the unfolded display and block the tab bar beside them when folded.

  • Cap the toasts at 600pt wide and center them, so they no longer span the unfolded display edge to edge.
  • Fix: Pass touches outside the toasts through to the app, so the folded Duo's rail tab bar beside them stays tappable.
  • Fix: Raise the dismiss ×'s contrast from about 2.5:1 to about 7:1. Previously, it drew in the toast's own color on a mid-gray circle and read as faint/invisible; the icon is unchanged.
  • Tweak: Round corners from 8 to 12px.
Before After

Changelog:
[General][Fixed] - LogBox: Fix bottom notification appearance/touch targets on iPhone Duo

Test Plan

yarn test packages/react-native/Libraries/LogBox

iPhone Duo, folded

Before Before, tab bar blocked After

✅ With both toasts showing, tapping the rail's APIs tab beside them does nothing before the change and switches tabs after it. Tapping a toast still opens the inspector.

iPhone Duo, unfolded

Before After

✅ The toasts span the display before the change and are capped and centered after it.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 8, 2026
@huntie huntie changed the title Fix LogBox notification toasts on iPhone Duo Tweak LogBox notifications for iPhone Duo, fix rail touches Oct 8, 2026
@huntie
huntie marked this pull request as ready for review October 8, 2026 15:29
@facebook-github-tools facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Oct 8, 2026
@meta-codesync

meta-codesync Bot commented Oct 8, 2026

Copy link
Copy Markdown

@Abbondanzo has imported this pull request. If you are a Meta employee, you can view this in D124115690.

@meta-codesync meta-codesync Bot closed this in 88a8bd2 Oct 8, 2026
@meta-codesync meta-codesync Bot added the Merged This PR has been merged. label Oct 8, 2026
@meta-codesync

meta-codesync Bot commented Oct 8, 2026

Copy link
Copy Markdown

@Abbondanzo merged this pull request in 88a8bd2.

@huntie
huntie deleted the pr58958 branch October 8, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Expo Partner: Expo Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants