Repository navigation
Lazily store safe area inset state (#58959) - #58959
Closed
Abbondanzo wants to merge 1 commit into
Closed
Abbondanzo wants to merge 1 commit into
Abbondanzo wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D124143204. |
Abbondanzo
force-pushed
the
export-D124143204
branch
from
October 8, 2026 18:45
6ea7541 to
653b8ad
Compare
meta-codesync
Bot
changed the title
Abbondanzo
added a commit
to Abbondanzo/react-native
that referenced
this pull request
Oct 8, 2026
Summary: Pull Request resolved: react#58959 `RCTViewComponentView` currently reserves a `UIEdgeInsets` value on every instance even though safe area observation is opt-in and rarely used. Store the last reported insets in an associated object only after a view starts emitting safe area inset changes, and clear that storage when observation stops or the view is recycled. Changelog: [Internal] Reviewed By: javache Differential Revision: D124143204
Abbondanzo
added a commit
to Abbondanzo/react-native
that referenced
this pull request
Oct 12, 2026
Summary: `RCTViewComponentView` currently reserves a `UIEdgeInsets` value on every instance even though safe area observation is opt-in and rarely used. Store the last reported insets in an associated object only after a view starts emitting safe area inset changes, and clear that storage when observation stops or the view is recycled. Changelog: [Internal] Reviewed By: javache Differential Revision: D124143204
Abbondanzo
force-pushed
the
export-D124143204
branch
from
October 12, 2026 00:43
653b8ad to
ad8bb25
Compare
Summary: Pull Request resolved: react#58959 `RCTViewComponentView` currently reserves a `UIEdgeInsets` value on every instance even though safe area observation is opt-in and rarely used. Store the last reported insets in an associated object only after a view starts emitting safe area inset changes, and clear that storage when observation stops or the view is recycled. Changelog: [Internal] Reviewed By: javache Differential Revision: D124143204
Abbondanzo
force-pushed
the
export-D124143204
branch
from
October 12, 2026 00:47
ad8bb25 to
a38bf37
Compare
|
This pull request has been merged in 8566016. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
RCTViewComponentViewcurrently reserves aUIEdgeInsetsvalue on everyinstance even though safe area observation is opt-in and rarely used. Store the
last reported insets in an associated object only after a view starts emitting
safe area inset changes, and clear that storage when observation stops or the
view is recycled.
Changelog: [Internal]
Reviewed By: javache
Differential Revision: D124143204