Repository navigation
Conversation
DevServerHelper opened and closed the packager connection in separate AsyncTasks on THREAD_POOL_EXECUTOR. A close could run before a pending open, and repeated opens could create two clients. Changing the bundle location from the dev menu also kept the old connection. In both cases, the old dev server could still reload the app. - Run openPackagerConnection and closePackagerConnection as tasks on one single-threaded executor. Tasks run in call order, off the UI thread, and only that thread uses packagerClient. The executor names its thread ReactPackagerConnection and stops it after 30 seconds without work. - Remember the host of the open client. If an open finds a client for a different host, close it and connect to the new host. - Check clientId on the caller's thread. A failed init() still crashes the app, as before; packagerClient stays null, so a later open can retry. - Change Bundle Location: close the packager connection before the reload, as setBundleSource does. Trim the input, then reject a host that OkHttp cannot parse in the connection URL and show a toast. Before, an invalid host was saved without a check. - ReconnectingWebSocket: change close state under the socket's monitor, so no message handler starts after closeQuietly() returns. Close a socket whose handshake finishes after closeQuietly() instead of reporting it as connected. - Add DevServerHelperTest, ReconnectingWebSocketTest and DevSupportHttpClientTest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
DevServerHelper opened and closed the inspector connection in separate
AsyncTasks, and the connection lives across reloads. After the dev
server host changed, the next open saw an existing connection and did
nothing, so the debugger stayed attached through the old Metro server.
- Run openInspectorConnection and closeInspectorConnection on the same
single-threaded executor as the packager connection.
- Remember the host of the open inspector connection. If an open finds a
connection for a different host, close it and connect to the new host.
- Make inspectorPackagerConnection volatile, because disableDebugger()
reads it from other threads.
- DevServerHelper no longer uses AsyncTask: remove the import, the
related comments, and @SuppressLint("StaticFieldLeak"). Lint reports
no StaticFieldLeak issue without it.
- Add inspector tests to DevServerHelperTest, with a test factory that
avoids the native connection class.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
meta-cla
Bot
added
the
CLA Signed
vonovak
marked this pull request as ready for review
October 12, 2026 22:02
facebook-github-tools
Bot
added
the
Shared with Meta
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
On Android, after an app switches to another Metro server, the debugger stays attached through the old one. The inspector connection lives across reloads, and
DevServerHelper.openInspectorConnectiondid nothing when a connection already existed, so it never moved to the new host. Open and close also ran in separateAsyncTasks, with the same ordering race that #58971 fixes for the packager connection.Changes:
inspectorPackagerConnectionis volatile, becausedisableDebugger()reads it from other threads.DevServerHelperno longer usesAsyncTask, so the import, the related comments and@SuppressLint("StaticFieldLeak")are gone. Lint reports noStaticFieldLeakissue without it.CxxInspectorPackagerConnection, which can't run under Robolectric.Possible follow-up: Change Bundle Location could also close the inspector connection before reloading, as it does for the packager connection, to cover a reload whose bundle fails to load.
Changelog:
[ANDROID] [FIXED] - Fix the debugger staying connected through the previous Metro server after switching to another one
Test Plan:
New tests in
DevServerHelperTestpass, and so do the existing related tests.On an emulator running RNTester with Metro on ports 8082 and 8083, I switched from 8082 to 8083 with Change Bundle Location. Before this change, Metro 8082 still listed the app in
/json/listminutes later and 8083 listed nothing. With this change, 8083 lists the app and 8082 drops it within seconds.🤖 Generated with Claude Code