Skip to content

Fix Android visible-password keyboard input type #59013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
YevheniiKotyrlo wants to merge 1 commit into from
Closed

Fix Android visible-password keyboard input type #59013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ve/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,7 +758,7 @@ public open class ReactTextInputManager public constructor() :
} else if (KEYBOARD_TYPE_VISIBLE_PASSWORD.equals(keyboardType, ignoreCase = true)) {
// This will supersede secureTextEntry={false}. If it doesn't, due to the way
// the flags work out, the underlying field will end up a URI-type field.
flagsToSet = InputType.TYPE_TEXT_VARIATION_VISIBLE_PASSWORD
flagsToSet = InputType.TYPE_CLASS_TEXT or InputType.TYPE_TEXT_VARIATION_VISIBLE_PASSWORD
} else if (KEYBOARD_TYPE_URI.equals(keyboardType, ignoreCase = true)) {
flagsToSet = InputType.TYPE_CLASS_TEXT or InputType.TYPE_TEXT_VARIATION_URI
}
Expand Down
7 changes: 2 additions & 5 deletions ...actAndroid/src/test/java/com/facebook/react/views/textinput/ReactTextInputPropertyTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,12 +386,9 @@ class ReactTextInputPropertyTest {

@Test
fun testKeyboardTypeVisiblePassword() {
val passwordVisibilityFlag =
InputType.TYPE_TEXT_VARIATION_VISIBLE_PASSWORD and
InputType.TYPE_TEXT_VARIATION_PASSWORD.inv()

manager.updateProperties(view, buildStyles("keyboardType", "visible-password"))
assertThat(view.inputType and generalKeyboardTypeFlags).isEqualTo(passwordVisibilityFlag)
assertThat(view.inputType and (InputType.TYPE_MASK_CLASS or InputType.TYPE_MASK_VARIATION))
.isEqualTo(InputType.TYPE_CLASS_TEXT or InputType.TYPE_TEXT_VARIATION_VISIBLE_PASSWORD)
}

@Test
Expand Down
Loading