Repository navigation
Fix Android safe-area transform round-off and notification precision - #59017
Closed
Abbondanzo wants to merge 1 commit into
Closed
Abbondanzo wants to merge 1 commit into
Abbondanzo wants to merge 1 commit into
Conversation
Summary: Cancelling transforms can leave floating-point skew that incorrectly disables Android safe-area updates. Bound accepted round-off by its displacement at the view's edges, and match iOS's one-physical-pixel change threshold without rounding the reported dp values. Unavailable geometry still emits no update rather than fabricated zero insets. Changelog: [Android][Fixed] - Preserve safe-area updates for cancelling transforms and match iOS notification precision. Differential Revision: D124830220
meta-cla
Bot
added
the
CLA Signed
|
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D124830220. |
|
This pull request has been merged in 95941fd. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Cancelling transforms can leave floating-point skew that incorrectly disables Android safe-area updates. Bound accepted round-off by its displacement at the view's edges, and match iOS's one-physical-pixel change threshold without rounding the reported dp values. Unavailable geometry still emits no update rather than fabricated zero insets.
Changelog:
[Android][Fixed] - Preserve safe-area updates for cancelling transforms and match iOS notification precision.
Differential Revision: D124830220