Repository navigation
[0.88][LOCAL] Set .hermesv1version to hermes-v260318099.0.4 - #59023
Open
YevheniiKotyrlo wants to merge 1 commit into
Open
YevheniiKotyrlo wants to merge 1 commit into
YevheniiKotyrlo wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
On
0.88-stable,sdks/.hermesv1versionis stillhermes-v260318099.0.2, while the Hermes bumps to 260318099.0.3 and 260318099.0.4 updated onlysdks/hermes-engine/version.propertiesand thehermes-compilerdependency. A build from source downloads the Hermes source at the.hermesv1versiontag (ReactAndroid/hermes-engine/build.gradle.kts, andpodspec_source_build_from_github_tagon iOS), so in 0.88.0-rc.5 it compiles Hermes 260318099.0.2, while every other build of the release ships 260318099.0.4.This sets the tag to
hermes-v260318099.0.4, the commithermes-compiler@260318099.0.4was published from.Changelog:
[GENERAL] [FIXED] - Build Hermes from source at the version the release ships
Test Plan:
npm view hermes-compiler@260318099.0.4 gitHeadprintsd412d3bd851278712c20cca25d094e32641a0465, the commithermes-v260318099.0.4points to.curl -sL https://github.com/facebook/hermes/tarball/hermes-v260318099.0.4 | tar -tz | head -1printsfacebook-hermes-d412d3b/.