Skip to content

Fix building Hermes from source on Windows failing on the JSI_DIR path #59024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
YevheniiKotyrlo wants to merge 1 commit into from
Closed

Fix building Hermes from source on Windows failing on the JSI_DIR path #59024

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/react-native/ReactAndroid/hermes-engine/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ val ndkBuildJobs = Runtime.getRuntime().availableProcessors().toString()
val prefabHeadersDir = File("$buildDir/prefab-headers")

// We inject the JSI directory used inside the Hermes build with the -DJSI_DIR config.
// CMake reads the backslashes of a Windows path as escape sequences, so we pass forward slashes.
val jsiDir = File(reactNativeRootDir, "ReactCommon/jsi")

val downloadHermesDest = File(downloadsDir, "hermes.tar.gz")
Expand Down Expand Up @@ -158,7 +159,7 @@ fun configureBuildForHermesCommandLineArgs(
".",
"-B",
hermesBuildDir.toString(),
"-DJSI_DIR=" + jsiDir.absolutePath,
"-DJSI_DIR=" + jsiDir.invariantSeparatorsPath,
"-DCMAKE_BUILD_TYPE=Release",
)
if (enableDebugger) {
Expand Down Expand Up @@ -340,7 +341,7 @@ android {
"-DANDROID_STL=c++_shared",
"-DANDROID_PIE=True",
"-DIMPORT_HOST_COMPILERS=${File(hermesBuildDir, "ImportHostCompilers.cmake").toString()}",
"-DJSI_DIR=${jsiDir}",
"-DJSI_DIR=${jsiDir.invariantSeparatorsPath}",
"-DHERMES_BUILD_SHARED_JSI=True",
"-DHERMES_RELEASE_VERSION=for RN ${version}",
"-DCMAKE_INTERPROCEDURAL_OPTIMIZATION=True",
Expand Down
Loading