Skip to content

Use umbrella headers in ImageProps.h and ComponentDescriptorFactory.h (#59025) #59025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
j-piasecki wants to merge 1 commit into from
Closed

Use umbrella headers in ImageProps.h and ComponentDescriptorFactory.h (#59025) #59025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/react-native/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,6 +465,7 @@ let reactCore = RNTarget(
let reactFabric = RNTarget(
name: .reactFabric,
path: "ReactCommon/react/renderer",
searchPaths: ["ReactCommon/react/renderer/imagemanager/platform/ios"], // ImageProps.h pulls in <React/ImageManager.h>; depending on reactImageManagerApple would be circular
excludedPaths: [
"animated/tests",
"animationbackend/tests",
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/React-Fabric.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,8 @@ Pod::Spec.new do |s|
"\"$(PODS_TARGET_SRCROOT)/react/renderer/core\"",
"\"$(PODS_TARGET_SRCROOT)/react/renderer/componentregistry\"",
"\"$(PODS_TARGET_SRCROOT)/react/renderer/debug\"",
"\"$(PODS_TARGET_SRCROOT)/react/renderer/imagemanager\"",
"\"$(PODS_TARGET_SRCROOT)/react/renderer/imagemanager/platform/ios\"",
]
end

Expand Down
1 change: 1 addition & 0 deletions packages/react-native/ReactCommon/react/renderer/animations/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ target_link_libraries(react_renderer_animations
react_renderer_graphics
react_renderer_mounting
react_renderer_uimanager
rrc_image
rrc_view
runtimeexecutor
yoga
Expand Down
8 changes: 3 additions & 5 deletions ...es/react-native/ReactCommon/react/renderer/componentregistry/ComponentDescriptorFactory.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,9 @@

#include <memory>

#include <react/renderer/core/ComponentDescriptor.h>
#include <react/renderer/core/EventDispatcher.h>
#include <react/utils/ContextContainer.h>

#include "ComponentDescriptorRegistry.h"
#include <React/ComponentRegistry.h>
#include <React/RendererCore.h>
#include <React/Utils.h>

namespace facebook::react {

Expand Down
8 changes: 4 additions & 4 deletions packages/react-native/ReactCommon/react/renderer/components/image/ImageProps.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@
#include <optional>
#include <string>

#include <react/renderer/components/view/ViewProps.h>
#include <react/renderer/core/PropsParserContext.h>
#include <react/renderer/graphics/Color.h>
#include <react/renderer/imagemanager/primitives.h>
#include <React/Graphics.h>
#include <React/ImageManager.h>
#include <React/RendererCore.h>
#include <React/View.h>

namespace facebook::react {

Expand Down
Loading