Repository navigation
Conversation
Summary: Move `componentNameByReactViewName.h` from the private tier back to the for-frameworks tier. The function maps legacy view names to Fabric component names. React Native itself only uses it inside the component registry and the iOS component view factory, and it is transitional, but libraries that integrate with the renderer call it directly; for example, an animation library uses it to resolve the component name for a view in its native module. Under `RN_STRICT_API` a private header is a hard error with no opt-out, so those libraries could not build at all. As for-frameworks, they get a warning that `RN_ALLOW_FRAMEWORKS` silences, and the function stays out of the public API. Changelog: [Internal] Differential Revision: D124970095
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D124970095. |
|
This pull request has been merged in d6d816c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Move
componentNameByReactViewName.hfrom the private tier back to the for-frameworks tier.The function maps legacy view names to Fabric component names. React Native itself only uses it inside the component registry and the iOS component view factory, and it is transitional, but libraries that integrate with the renderer call it directly; for example, an animation library uses it to resolve the component name for a view in its native module. Under
RN_STRICT_APIa private header is a hard error with no opt-out, so those libraries could not build at all. As for-frameworks, they get a warning thatRN_ALLOW_FRAMEWORKSsilences, and the function stays out of the public API.Changelog: [Internal]
Differential Revision: D124970095