Repository navigation
Cover react/nativemodule/viewtransition with Stable API guards (#59058) - #59058
Open
j-piasecki wants to merge 1 commit into
Open
j-piasecki wants to merge 1 commit into
j-piasecki wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D125183881. |
…ct#59058) Summary: Marks `react/nativemodule/viewtransition` as a private target under the C++ Stable API: `NativeViewTransition.h` includes `<react/cxxstableapi/PrivateGuard.h>`, and BUCK, CMake, and the podspec depend on `cxxstableapi`. The guard is inert unless `RN_STRICT_API` is defined, so there is no behavior change. Changelog: [Internal] ___ landed-with-radar-review Differential Revision: D125183881
meta-codesync
Bot
changed the title
react/nativemodule/viewtransition with Stable API guardsreact/nativemodule/viewtransition with Stable API guards (#59058)
j-piasecki
force-pushed
the
export-D125183881
branch
from
October 14, 2026 09:42
c709919 to
d72070b
Compare
cortinico
approved these changes
Oct 14, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Marks
react/nativemodule/viewtransitionas a private target under the C++ Stable API:NativeViewTransition.hincludes<react/cxxstableapi/PrivateGuard.h>, and BUCK, CMake, and the podspec depend oncxxstableapi. The guard is inert unlessRN_STRICT_APIis defined, so there is no behavior change.Changelog: [Internal]
landed-with-radar-review
Differential Revision: D125183881