Repository navigation
Conversation
meta-cla
Bot
added
the
CLA Signed
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
facebook-github-tools
Bot
added
the
Shared with Meta
|
@Abbondanzo has imported this pull request. If you are a Meta employee, you can view this in D125233750. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
PushNotificationIOShas been deprecated since it moved to@react-native-community/push-notification-ios. This PR removes it from core: the JS module,RCTPushNotificationManager, theReact-RCTPushNotificationpod, and theRCTPushNotificationHeaderssubspec. In__DEV__, readingPushNotificationIOSnow throws an error that points to the community package.Changelog:
[IOS] [BREAKING] - Remove deprecated
PushNotificationIOSTest Plan:
Commands I ran, and their results:
yarn flow-check: 0 errorsyarn build-types && yarn test-generated-typescript: passedyarn eslint --max-warnings 0on changed JS files: cleanyarn teston affected packages: 608 tests passedyarn cxx-api-build: Apple snapshots updated