Skip to content

feat: print parse* results as JSON without the bundle bytes - #100

Merged
sunnylqm merged 1 commit into
masterfrom
claude/parseapk-content-fingerprint-751dca
Oct 14, 2026
Merged

sunnylqm merged 1 commit into
masterfrom
claude/parseapk-content-fingerprint-751dca

Conversation

@sunnylqm

@sunnylqm sunnylqm commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

parseApk / parseIpa / parseApp / parseAab now print pretty JSON and omit the raw bundleFile Buffer, so the bundleHash content fingerprint (sha256 of the embedded JS bundle) is clean to read.

  • Verified: bun test (585 pass), lint, build, Node 18 smoke; real parseApp run on Node 18 matches shasum -a 256 of the bundle.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Summary by CodeRabbit

  • Changes
    • Package parsing commands now display formatted JSON metadata, including a bundle hash and app credentials, without outputting the bundle contents.

parseApk / parseIpa / parseApp / parseAab now print the package info as
pretty JSON and drop the raw bundleFile Buffer, so the bundleHash content
fingerprint is easy to read and copy.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 63383e08-6091-4f8a-b444-db091b0e1ade
📥 Commits

Reviewing files that changed from the base of the PR and between b86803b and 708dcb8.

📒 Files selected for processing: 2
  • src/package.ts
  • tests/package.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The four package parse commands now print parser results as indented JSON without the bundleFile field. Their extension checks and parser selection are unchanged. A new test checks the JSON output for a Harmony .app archive.

Changes: Package parser output

Layer / File(s) Summary
Format parser results and verify output
src/package.ts, tests/package.test.ts
A shared helper prints parser results as indented JSON without bundleFile. The four parse commands use the helper. The new parseApp test checks the metadata, credentials, and SHA-256 bundle hash in the logged JSON.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 708dc

The parse commands now print readable JSON without the bundle bytes, and a test covers the parseApp output. No actionable merge risk is apparent.

Pre-merge checks: Passed 5
Passed Passed checks: 5 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly summarizes the main change: parse commands print JSON results without the raw bundle bytes.
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sunnylqm
sunnylqm merged commit ca5816e into master Oct 14, 2026
9 checks passed
@sunnylqm
sunnylqm deleted the claude/parseapk-content-fingerprint-751dca branch October 14, 2026 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant