Skip to content

[RHDHBUGS-2140]: Add missing --v2 flag to oc-mirror command in air-gapped install#2147

Open
themr0c wants to merge 2 commits intoredhat-developer:mainfrom
themr0c:RHDHBUGS-2140-oc-mirror-v2
Open

[RHDHBUGS-2140]: Add missing --v2 flag to oc-mirror command in air-gapped install#2147
themr0c wants to merge 2 commits intoredhat-developer:mainfrom
themr0c:RHDHBUGS-2140-oc-mirror-v2

Conversation

@themr0c
Copy link
Copy Markdown
Member

@themr0c themr0c commented Apr 30, 2026

IMPORTANT: Do Not Merge
This PR is not ready to merge until technical review is complete and all comments are addressed.

Version(s)

1.8+

Issue

https://redhat.atlassian.net/browse/RHDHBUGS-2140

Preview

N/A

Summary

  • Adds the required --v2 flag to the oc mirror command in the partially disconnected Helm air-gapped install procedure
  • Updates command syntax from v1 (oc-mirror --config=...) to v2 (oc mirror --v2 -c ...) to match the fully disconnected procedure
  • Fixes the stale NOTE that referenced ImageContentSourcePolicy (ICSP, v1 output) — replaced with ImageDigestMirrorSet/ImageTagMirrorSet (IDMS/ITMS, v2 output) to match the subsequent steps

Test plan

  • Compare command format with the fully disconnected Helm procedure for consistency
  • Verify the NOTE block now matches v2 output terminology (IDMS/ITMS)
  • Confirm the docker:// prefix is in the command and not duplicated in the variable description

🤖 Generated with Claude Code

…pped install

The partially disconnected Helm air-gapped install used the v1
oc-mirror syntax without the --v2 flag, which is now required.
Update the command to match the v2 syntax already used in the fully
disconnected procedure. Also fix the stale NOTE that referenced ICSP
(v1 output) instead of IDMS/ITMS (v2 output).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@rhdh-bot
Copy link
Copy Markdown
Collaborator

rhdh-bot commented Apr 30, 2026

PR Build Results

Build passed -- 34/34 titles | 75s
Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-2147/


Content Quality Assessment

CQA Report

  • CQA-00a: Orphaned modules
  • CQA-00b: Directory structure
  • CQA-01: Vale AsciiDoc DITA compliance
  • CQA-02: Verify assembly structure
  • CQA-03: Verify content type metadata
  • CQA-04: Verify module templates
  • CQA-05: Verify required modular elements
  • CQA-06: Verify assemblies follow official template (one user story)
  • CQA-07: Verify TOC depth (max 3 levels)
  • CQA-08: Verify short description content quality
  • CQA-09: Verify short description format
  • CQA-10: Verify titles are brief, complete, and descriptive
  • CQA-11: Verify procedure prerequisites
  • CQA-12: Verify grammar and style (Vale)
  • CQA-13: Verify content matches declared type
  • CQA-14: Verify no broken links
  • CQA-15: Check redirects
  • CQA-16: Verify official product names
  • CQA-17: Verify legal disclaimers for preview features

Summary

Checks: 19 total, 19 pass, 0 fail

19 checks: 19 pass, 0 fail

Run node build/scripts/cqa/index.js --all --fix locally to review and auto-fix issues.


Updated 2026-04-30 10:36:48 UTC

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Member

@rh-tokeefe rh-tokeefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants