Skip to content

feat(prepare-sources): closer sync-midstream parity (yarn ensure + nmMode) - #173

Open
polasudo wants to merge 2 commits into
redhat-developer:mainfrom
polasudo:RHIDP-closer-to-sync-midstream
Open

polasudo wants to merge 2 commits into
redhat-developer:mainfrom
polasudo:RHIDP-closer-to-sync-midstream

Conversation

@polasudo

Copy link
Copy Markdown
Contributor

Summary

  • hermetic-prep: ensure Yarn binary via yarnPath (download from packageManager when missing) before stripping packageManager, matching sync-midstream Loop 2
  • make-self-contained: remove nmMode after yarnrc merge (sync-midstream flatten — hardlinks break npm pack + bundleDependencies)
  • Fixtures + tests for both behaviors; vp check / vp test at 100% coverage

Why a separate branch

Incremental parity toward RHIDP-15847 e2e without merging into main yet. Leaves inject-build-tools path skew intentional (file:.yarn/cache).

Test plan

  • cd prepare-sources && npm run check && npm test
  • CI green on this PR
  • Review against sync-midstream Loop 2 / flatten for remaining gaps

Made with Cursor

@polasudo
polasudo force-pushed the RHIDP-closer-to-sync-midstream branch from 101c853 to 37b1bda Compare October 1, 2026 08:52
@sonarqubecloud

sonarqubecloud Bot commented Oct 1, 2026

Copy link
Copy Markdown

polasudo and others added 2 commits November 5, 2026 16:33
…th sync-midstream

Ensure Yarn via yarnPath (download from packageManager) before stripping
packageManager, and drop nmMode after yarnrc merge so export matches
sync-midstream Loop 2 / flatten behavior.

Co-authored-by: Cursor <cursoragent@cursor.com>
Extract shared helpers so Sonar new_duplicated_lines stays under the
quality-gate threshold on the sync-midstream parity PR.

Co-authored-by: Cursor <cursoragent@cursor.com>
@polasudo
polasudo force-pushed the RHIDP-closer-to-sync-midstream branch from 83de40b to 75b0233 Compare November 5, 2026 15:41
@sonarqubecloud

sonarqubecloud Bot commented Nov 5, 2026

Copy link
Copy Markdown

@polasudo
polasudo requested review from davidfestal and jonkoops and removed request for jonkoops November 6, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant