fix(theme): use &.Mui-selected syntax for MuiBottomNavigationAction#3065
Open
Eswaraiahsapram wants to merge 1 commit intoredhat-developer:mainfrom
Open
Conversation
…Action MUI requires selected state styles to be nested inside root using the '&.Mui-selected' selector instead of a top-level 'selected' key in styleOverrides. The previous approach caused a CSS specificity warning in the console. Assisted-by: Cursor Co-authored-by: Cursor <cursoragent@cursor.com>
Changed Packages
|
Eswaraiahsapram
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3065 +/- ##
=======================================
Coverage 60.78% 60.78%
=======================================
Files 2067 2067
Lines 63873 63873
Branches 16580 16580
=======================================
Hits 38827 38827
Misses 24793 24793
Partials 253 253
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes RHDHBUGS-2291
MuiBottomNavigationActiontheme override in the RHDH theme plugin usedselectedas a top-level key instyleOverrides, which MUI does not support for internal state overrides.rootusing the&.Mui-selectedCSS selector, as recommended by MUI.Test Plan
yarn start:legacyinworkspaces/themeand verify no MUI console warning aboutMuiBottomNavigationActiontsc --noEmit --skipLibCheck)Assisted-by: Cursor
Hey, I just made a Pull Request!
✔️ Checklist