fix(lightspeed): add return statement to address unhandled error in /v1/feedback #3070
Merged
Jdubrick merged 3 commits intoredhat-developer:mainfrom May 8, 2026
Merged
Conversation
Jdubrick
requested review from
a team,
karthikjeeyar,
rohitkrai03 and
yangcao77
as code owners
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require review |
Changed Packages
|
Review Summary by QodoFix unhandled error in lightspeed /v1/feedback handler
WalkthroughsDescription• Add missing return statement in /v1/feedback error handler • Prevents unhandled error fallthrough after 500 response • Add test case for upstream server error handling Diagramflowchart LR
A["POST /v1/feedback"] --> B["Upstream 500 Error"]
B --> C["Send 500 Response"]
C --> D["Add return statement"]
D --> E["Prevent Fallthrough"]
File Changes1. workspaces/lightspeed/plugins/lightspeed-backend/src/service/router.ts
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3070 +/- ##
=======================================
Coverage 57.28% 57.28%
=======================================
Files 2067 2067
Lines 63528 63529 +1
Branches 16583 16585 +2
=======================================
+ Hits 36390 36395 +5
+ Misses 26704 26700 -4
Partials 434 434
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
gabemontero
reviewed
May 7, 2026
Contributor
gabemontero
left a comment
gabemontero
left a comment
There was a problem hiding this comment.
one question (answers might lead to an actual ask for change)
…handled error Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Jdubrick
force-pushed
the
fix-lightspeed-feedback-error-handling
branch
from
b3589db to
2d573c9
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
✔️ Checklist
Adds a
returnstatement to the/v1/feedbackhandler when it gets a 500 error, it was the only one missing this out of all the route handlers.Issue: https://redhat.atlassian.net/browse/RHIDP-13063