Repository navigation
Register .jsh as a java-language file extension - #4572
Open
robstryker wants to merge 1 commit into
Open
robstryker wants to merge 1 commit into
robstryker wants to merge 1 commit into
Conversation
Routes .jsh (JShell script) files through the same LSP document selector as .java files (keyed by language id, not extension), so the classpath-aware .jsh content assist implemented server-side in eclipse.jdt.ls (eclipse-jdtls/eclipse.jdt.ls#3973) actually gets used by the client. Deliberately last: the server-side pipeline (completion, diagnostics, hover, plus guardrails on save/organize-imports) was proven out and hardened first, since any client sending .jsh requests exercises all of that immediately once this lands. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.jsh(JShell script) files as thejavalanguage inpackage.json, so they're routed through the existing{ scheme: 'file', language: 'java' }LSP document selector with no other client changes needed..jshfiles implemented entirely server-side in jdt.ls: Classpath-aware content assist for .jsh (JShell script) files eclipse-jdtls/eclipse.jdt.ls#3974 (fixes Content assist for .jsh (JShell script) files without upstream JShell grammar support eclipse-jdtls/eclipse.jdt.ls#3973)..jshfiles on save/organize-imports) before wiring up a real client to send these requests.Originated from #1601.
Test plan
package.jsonvalidated as well-formed JSON.jshfile, confirm Java syntax highlighting and classpath-aware completion/hover/diagnostics work