Skip to content

RI-8007 Add e2e tests for Browser - String Key details view#5873

Open
valkirilov wants to merge 1 commit into
e2e/RI-8005/key-tree-view-testsfrom
e2e/RI-8007/key-details-string-tests
Open

RI-8007 Add e2e tests for Browser - String Key details view#5873
valkirilov wants to merge 1 commit into
e2e/RI-8005/key-tree-view-testsfrom
e2e/RI-8007/key-details-string-tests

Conversation

@valkirilov
Copy link
Copy Markdown
Member

@valkirilov valkirilov commented May 8, 2026

What

Adds e2e tests for the Browser - Key Details (String) view, covering view of the seeded value, copy-key-name button on hover, value edit with a Redis-side cross-check via GET, rename and propagation back to the Key List, view / edit TTL with countdown to expiry (the key disappears from the list once the TTL ticks down), and value format switching across Unicode / HEX / Binary.

Follow-up of #5865 — based on e2e/RI-8005/key-tree-view-tests so the diff stays scoped to key-details (String) changes.

Testing

Run the Docker containers with the test database instances

cd tests/e2e
docker-compose -f rte.docker-compose.yml up -d

And then you can run the tests

cd tests/e2e-playwright
npm run test:chromium -- tests/main/browser/key-details/string-details.spec.ts
image

Closes #RI-8007


Note

Low Risk
Low risk since changes are isolated to Playwright E2E tests and documentation, with no production code impact; main risk is potential test flakiness around TTL countdown/expiry polling.

Overview
Adds a new Playwright spec for Browser → Key Details (String) covering viewing/editing a seeded string value (with Redis-side GET verification), rename propagation back to the key list, copy-key-name on hover, TTL edit with expiry countdown (asserting the key disappears), and switching value formats (Unicode/HEX/Binary).

Updates TEST_PLAN.md to mark these String key-details test cases as implemented and consolidate them into three concrete specs.

Reviewed by Cursor Bugbot for commit e6c39e9. Bugbot is set up for automated code reviews on this repo. Configure here.

@valkirilov valkirilov requested a review from a team as a code owner May 8, 2026 09:59
@valkirilov valkirilov self-assigned this May 8, 2026
@jit-ci
Copy link
Copy Markdown

jit-ci Bot commented May 8, 2026

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR


Security scan by Jit

@valkirilov valkirilov changed the base branch from main to e2e/RI-8005/key-tree-view-tests May 8, 2026 12:05
@valkirilov valkirilov force-pushed the e2e/RI-8007/key-details-string-tests branch from 16c0516 to 32bd9b7 Compare May 8, 2026 12:06
@valkirilov valkirilov force-pushed the e2e/RI-8005/key-tree-view-tests branch from e252ae9 to fc49194 Compare May 8, 2026 13:03
@valkirilov valkirilov force-pushed the e2e/RI-8007/key-details-string-tests branch from 32bd9b7 to c048748 Compare May 8, 2026 13:04
@valkirilov valkirilov force-pushed the e2e/RI-8007/key-details-string-tests branch from c048748 to 906d0c9 Compare May 9, 2026 07:25
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 906d0c9. Configure here.

@valkirilov valkirilov force-pushed the e2e/RI-8005/key-tree-view-tests branch from cb42d24 to a883af9 Compare May 9, 2026 07:32
@valkirilov valkirilov force-pushed the e2e/RI-8007/key-details-string-tests branch from 906d0c9 to dd72667 Compare May 9, 2026 07:34
Adds consolidated Playwright E2E coverage for the Browser Key Details
String view: view value, copy-key-name on hover, edit value with
Redis-side cross-check, rename and propagation to the Key List,
view/edit TTL with countdown to expiry, and value format switching
across Unicode / HEX / Binary.

Updates TEST_PLAN section 2.4 to mark the three consolidated scenarios
as implemented.

References: #RI-8007
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@valkirilov valkirilov force-pushed the e2e/RI-8007/key-details-string-tests branch from dd72667 to e6c39e9 Compare May 9, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants