RI-8007 Add e2e tests for Browser - String Key details view#5873
Open
valkirilov wants to merge 1 commit into
Open
RI-8007 Add e2e tests for Browser - String Key details view#5873valkirilov wants to merge 1 commit into
valkirilov wants to merge 1 commit into
Conversation
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
16c0516 to
32bd9b7
Compare
e252ae9 to
fc49194
Compare
32bd9b7 to
c048748
Compare
c048748 to
906d0c9
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 906d0c9. Configure here.
cb42d24 to
a883af9
Compare
906d0c9 to
dd72667
Compare
Adds consolidated Playwright E2E coverage for the Browser Key Details String view: view value, copy-key-name on hover, edit value with Redis-side cross-check, rename and propagation to the Key List, view/edit TTL with countdown to expiry, and value format switching across Unicode / HEX / Binary. Updates TEST_PLAN section 2.4 to mark the three consolidated scenarios as implemented. References: #RI-8007 Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
dd72667 to
e6c39e9
Compare
KrumTy
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
Adds e2e tests for the Browser - Key Details (String) view, covering view of the seeded value, copy-key-name button on hover, value edit with a Redis-side cross-check via
GET, rename and propagation back to the Key List, view / edit TTL with countdown to expiry (the key disappears from the list once the TTL ticks down), and value format switching across Unicode / HEX / Binary.Follow-up of #5865 — based on
e2e/RI-8005/key-tree-view-testsso the diff stays scoped to key-details (String) changes.Testing
Run the Docker containers with the test database instances
And then you can run the tests
Closes #RI-8007
Note
Low Risk
Low risk since changes are isolated to Playwright E2E tests and documentation, with no production code impact; main risk is potential test flakiness around TTL countdown/expiry polling.
Overview
Adds a new Playwright spec for Browser → Key Details (String) covering viewing/editing a seeded string value (with Redis-side
GETverification), rename propagation back to the key list, copy-key-name on hover, TTL edit with expiry countdown (asserting the key disappears), and switching value formats (Unicode/HEX/Binary).Updates
TEST_PLAN.mdto mark these String key-details test cases as implemented and consolidate them into three concrete specs.Reviewed by Cursor Bugbot for commit e6c39e9. Bugbot is set up for automated code reviews on this repo. Configure here.