RI-8160: implement preview x out of y for similarity search results#5890
Open
dantovska wants to merge 1 commit into
Open
Conversation
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
Contributor
Code Coverage - Frontend unit tests
Test suite run success6860 tests passing in 793 suites. Report generated by 🧪jest coverage report action from 8d1851a |
KrumTy
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add X out of Y in the subheader for similarity search results, where X is result count, and Y is the total elements count.
Testing
Note
Low Risk
Low risk UI-only change that adjusts how the Vector Set subheader computes and displays preview counts; main risk is minor incorrect counts/visibility in edge cases (pagination vs similarity results).
Overview
Adds a preview summary to the Vector Set subheader that also works for similarity search, showing “Previewing X out of Y” where
Xis the number of matches currently displayed andYis the vector set total.Refactors
VectorSetKeySubheaderto be driven by explicit props (showPreview,previewCount,total) instead of reading from Redux directly, withVectorSetDetailsnow computing these values and giving similarity results precedence over the element-list preview. Updates the subheader unit tests accordingly to validate the new prop-driven behavior.Reviewed by Cursor Bugbot for commit 8d1851a. Bugbot is set up for automated code reviews on this repo. Configure here.