[unfinished, abandoned, needs rebase] Refactor network stack to Axum and Hyper v1#548
Draft
Tokarak wants to merge 53 commits intoredlib-org:mainfrom
Draft
[unfinished, abandoned, needs rebase] Refactor network stack to Axum and Hyper v1#548Tokarak wants to merge 53 commits intoredlib-org:mainfrom
Tokarak wants to merge 53 commits intoredlib-org:mainfrom
Conversation
The interaction with the rest of the codebase is a little ugly, but functionality is practically the same.
Refactor `main::fetch_instances()` and `main::fetch_commit_info()` Enabled deprecated warnings in hyper crate
Settings encoded_restore was updated main.rs now temporarily uses map_error to map into strings. Later, the ApiError should be converted into a Response<Body> using the crate's utilities.
Note: current implementation is broken, since the url query isn't forwarded.
Preparations to port post::item
Fix bug with Preferences::from_request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More than a year ago I tried to manually migrate the network stack to the Axum library. I never finished. However, what I have started might be able to be completed using a vibecoding tool (either now or in the future). I'm publishing my code in case anybody wants to finish the task. I regret not pushing my changes earlier.
For testing purposes, most of the old networking stack has been left in. I planned to remove it when the migration was complete.
If anybody ever upgrades to Hyper v1, there are some changes here that could be ported, such as using the Cookiejar library (which depends on Hyper v1 under the hood, I think); and the reqwest library for Redlib<->Reddit http interactions.
Related: #46, #395