docs (k8s): Move inline YAML examples to feature files for schema and topic controllers#1650
Conversation
…ollers Extract inline examples from k-schema-controller.adoc (full compatibility schema, schema references) and k-manage-topics.adoc (write caching topic, cleanup policy topic) into their respective feature files with proper tags so they follow the same include pattern as existing examples. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for redpanda-docs-preview ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughAdded new Kubernetes example BDD scenarios and updated docs to include them. Three skipped Schema CRD scenarios were added to modules/manage/examples/kubernetes/schema-crds.feature covering full compatibility, backward compatibility, and a schema with a reference to another schema. Two skipped Topic CRD scenarios were added to modules/manage/examples/kubernetes/topic-crds.feature for write caching and delete cleanup policy. Documentation pages (k-manage-topics.adoc and k-schema-controller.adoc) were updated to replace inline YAML examples with AsciiDoc includes referencing the new feature snippets. A small paragraph in the schema-registry ACLs doc was moved for improved placement. Sequence Diagram(s)(omitted) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
modules/manage/pages/kubernetes/k-schema-controller.adoc (1)
188-193: Consider adding documentation about the prerequisite schema.The included example references a
productschema that must exist before applying this manifest:references: - name: product-schema subject: product version: 1Consider adding a note before this example explaining that the referenced schema must be created first, similar to how other documentation sections explain prerequisites.
Suggested addition
Define a schema reference using the `references` field. The reference includes the name, subject, and version of the referenced schema: +NOTE: The referenced schema (in this case, a schema with subject `product`) must already exist in the Schema Registry before applying a schema that references it. + [,yaml,indent=0] ---- include::manage:example$kubernetes/schema-crds.feature[tags=schema-references-manifest,indent=0] ----🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@modules/manage/pages/kubernetes/k-schema-controller.adoc` around lines 188 - 193, Add a short prerequisite note before the YAML example that uses the references field to explain the referenced schema must exist beforehand; specifically mention that the example's reference (name: product-schema, subject: product, version: 1) requires the corresponding product schema to be created prior to applying this manifest so users know to create that schema first.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@modules/manage/examples/kubernetes/schema-crds.feature`:
- Around line 142-175: The scenario for Schema named "order-schema" references a
non-existent dependency "product-schema" (subject: "product", version: 1),
causing sync/compatibility to fail; fix by either adding a preceding scenario
that creates the referenced schema (e.g., create a Schema resource named
"product-schema" with subject "product" and version 1 and ensure it's synced
before the order-schema scenario) or change the references block in the
"order-schema" manifest to point to an existing schema in this feature (for
example replace name/subject with the existing "product-catalog" schema and its
correct subject/version) so the reference can be resolved at test time.
In `@modules/manage/examples/kubernetes/topic-crds.feature`:
- Around line 55-79: The topic name "compacted-topic" conflicts with its
configured cleanup.policy of "delete"; fix this by either renaming the Topic
metadata.name from "compacted-topic" to a name matching the delete semantics
(e.g., "retained-topic" or "delete-policy-topic") or change
spec.additionalConfig.cleanup.policy from "delete" to "compact" so the name and
policy align; update the Scenario text and any referenced steps that mention
"compacted-topic" to the new name to keep the test consistent.
---
Nitpick comments:
In `@modules/manage/pages/kubernetes/k-schema-controller.adoc`:
- Around line 188-193: Add a short prerequisite note before the YAML example
that uses the references field to explain the referenced schema must exist
beforehand; specifically mention that the example's reference (name:
product-schema, subject: product, version: 1) requires the corresponding product
schema to be created prior to applying this manifest so users know to create
that schema first.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: cf33fb5c-a968-4f11-81fb-b1b9c3a24cd6
📒 Files selected for processing (5)
modules/manage/examples/kubernetes/schema-crds.featuremodules/manage/examples/kubernetes/topic-crds.featuremodules/manage/pages/kubernetes/k-manage-topics.adocmodules/manage/pages/kubernetes/k-schema-controller.adocmodules/manage/pages/kubernetes/security/authentication/k-schema-registry-acls.adoc
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add prerequisite "product-schema" scenario before "order-schema" to ensure the referenced schema exists when testing schema references - Update order-schema scenario to check for product-schema prerequisite - Rename "compacted-topic" to "delete-policy-topic" to match the cleanup.policy: "delete" configuration Addresses CodeRabbit feedback at: https://github.com/redpanda-data/docs/pull/1650/changes#r3023139360 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Add new scenarios to schema-crds.feature: - Manage fully compatible schema (Avro) - demonstrates Full compatibility level - Manage product schema (Avro) - prerequisite for schema references example - Manage order schema with references (Avro) - demonstrates schema references Add new scenarios to topic-crds.feature: - Manage topic with write caching - demonstrates write.caching configuration - Manage topic with cleanup policy - demonstrates cleanup.policy configuration These examples will be referenced in docs PR #1650: redpanda-data/docs#1650 Fixes from CodeRabbit review: - Added prerequisite product-schema before order-schema to ensure referenced schema exists - Named delete-policy-topic appropriately to match cleanup.policy: "delete"
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Summary
k-schema-controller.adoc(full compatibility schema, schema references) intoschema-crds.featurewith proper tags and include directivesk-manage-topics.adoc(write caching topic, cleanup policy topic) intotopic-crds.featurewith proper tags and include directivesTest plan
🤖 Generated with Claude Code