Skip to content

docs (k8s): Move inline YAML examples to feature files for schema and topic controllers#1650

Merged
JakeSCahill merged 5 commits intoredpanda-data:mainfrom
david-yu:docs/schema-registry-acls-operator-v2
Apr 13, 2026
Merged

docs (k8s): Move inline YAML examples to feature files for schema and topic controllers#1650
JakeSCahill merged 5 commits intoredpanda-data:mainfrom
david-yu:docs/schema-registry-acls-operator-v2

Conversation

@david-yu
Copy link
Copy Markdown
Contributor

@david-yu david-yu commented Apr 1, 2026

Summary

  • Extract inline YAML examples from k-schema-controller.adoc (full compatibility schema, schema references) into schema-crds.feature with proper tags and include directives
  • Extract inline YAML examples from k-manage-topics.adoc (write caching topic, cleanup policy topic) into topic-crds.feature with proper tags and include directives
  • Ensures all concrete YAML examples follow the same pattern: stored in feature files for testability, included via tags in documentation

Test plan

  • Verify the schema controller page renders correctly with the included examples
  • Verify the manage topics page renders correctly with the included examples
  • Confirm feature file tags are properly extracted in the Antora build

🤖 Generated with Claude Code

…ollers

Extract inline examples from k-schema-controller.adoc (full compatibility
schema, schema references) and k-manage-topics.adoc (write caching topic,
cleanup policy topic) into their respective feature files with proper tags
so they follow the same include pattern as existing examples.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@david-yu david-yu requested a review from a team as a code owner April 1, 2026 16:12
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 1, 2026

Deploy Preview for redpanda-docs-preview ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b8be944
🔍 Latest deploy log https://app.netlify.com/projects/redpanda-docs-preview/deploys/69dce4b7a1638b0008e12302
😎 Deploy Preview https://deploy-preview-1650--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 1, 2026

📝 Walkthrough

Walkthrough

Added new Kubernetes example BDD scenarios and updated docs to include them. Three skipped Schema CRD scenarios were added to modules/manage/examples/kubernetes/schema-crds.feature covering full compatibility, backward compatibility, and a schema with a reference to another schema. Two skipped Topic CRD scenarios were added to modules/manage/examples/kubernetes/topic-crds.feature for write caching and delete cleanup policy. Documentation pages (k-manage-topics.adoc and k-schema-controller.adoc) were updated to replace inline YAML examples with AsciiDoc includes referencing the new feature snippets. A small paragraph in the schema-registry ACLs doc was moved for improved placement.

Sequence Diagram(s)

(omitted)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • chrisseto
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description lacks required template sections including a JIRA ticket reference, review deadline, page previews, and check categories. Add the missing required sections from the template: Resolves link with JIRA ticket, Review deadline, Page previews URLs, and mark appropriate checkboxes (Content gap and Small fix appear relevant).
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: moving inline YAML examples from documentation files into feature files for schema and topic controllers.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (1)
modules/manage/pages/kubernetes/k-schema-controller.adoc (1)

188-193: Consider adding documentation about the prerequisite schema.

The included example references a product schema that must exist before applying this manifest:

references:
  - name: product-schema
    subject: product
    version: 1

Consider adding a note before this example explaining that the referenced schema must be created first, similar to how other documentation sections explain prerequisites.

Suggested addition
 Define a schema reference using the `references` field. The reference includes the name, subject, and version of the referenced schema:

+NOTE: The referenced schema (in this case, a schema with subject `product`) must already exist in the Schema Registry before applying a schema that references it.
+
 [,yaml,indent=0]
 ----
 include::manage:example$kubernetes/schema-crds.feature[tags=schema-references-manifest,indent=0]
 ----
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@modules/manage/pages/kubernetes/k-schema-controller.adoc` around lines 188 -
193, Add a short prerequisite note before the YAML example that uses the
references field to explain the referenced schema must exist beforehand;
specifically mention that the example's reference (name: product-schema,
subject: product, version: 1) requires the corresponding product schema to be
created prior to applying this manifest so users know to create that schema
first.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@modules/manage/examples/kubernetes/schema-crds.feature`:
- Around line 142-175: The scenario for Schema named "order-schema" references a
non-existent dependency "product-schema" (subject: "product", version: 1),
causing sync/compatibility to fail; fix by either adding a preceding scenario
that creates the referenced schema (e.g., create a Schema resource named
"product-schema" with subject "product" and version 1 and ensure it's synced
before the order-schema scenario) or change the references block in the
"order-schema" manifest to point to an existing schema in this feature (for
example replace name/subject with the existing "product-catalog" schema and its
correct subject/version) so the reference can be resolved at test time.

In `@modules/manage/examples/kubernetes/topic-crds.feature`:
- Around line 55-79: The topic name "compacted-topic" conflicts with its
configured cleanup.policy of "delete"; fix this by either renaming the Topic
metadata.name from "compacted-topic" to a name matching the delete semantics
(e.g., "retained-topic" or "delete-policy-topic") or change
spec.additionalConfig.cleanup.policy from "delete" to "compact" so the name and
policy align; update the Scenario text and any referenced steps that mention
"compacted-topic" to the new name to keep the test consistent.

---

Nitpick comments:
In `@modules/manage/pages/kubernetes/k-schema-controller.adoc`:
- Around line 188-193: Add a short prerequisite note before the YAML example
that uses the references field to explain the referenced schema must exist
beforehand; specifically mention that the example's reference (name:
product-schema, subject: product, version: 1) requires the corresponding product
schema to be created prior to applying this manifest so users know to create
that schema first.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cf33fb5c-a968-4f11-81fb-b1b9c3a24cd6

📥 Commits

Reviewing files that changed from the base of the PR and between c4f9842 and ad223a7.

📒 Files selected for processing (5)
  • modules/manage/examples/kubernetes/schema-crds.feature
  • modules/manage/examples/kubernetes/topic-crds.feature
  • modules/manage/pages/kubernetes/k-manage-topics.adoc
  • modules/manage/pages/kubernetes/k-schema-controller.adoc
  • modules/manage/pages/kubernetes/security/authentication/k-schema-registry-acls.adoc

david-yu and others added 2 commits April 1, 2026 15:45
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@david-yu david-yu changed the title Move inline YAML examples to feature files for schema and topic controllers docs (k8s): Move inline YAML examples to feature files for schema and topic controllers Apr 1, 2026
JakeSCahill and others added 2 commits April 13, 2026 13:41
- Add prerequisite "product-schema" scenario before "order-schema"
  to ensure the referenced schema exists when testing schema references
- Update order-schema scenario to check for product-schema prerequisite
- Rename "compacted-topic" to "delete-policy-topic" to match the
  cleanup.policy: "delete" configuration

Addresses CodeRabbit feedback at:
https://github.com/redpanda-data/docs/pull/1650/changes#r3023139360

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
JakeSCahill added a commit to redpanda-data/redpanda-operator that referenced this pull request Apr 13, 2026
Add new scenarios to schema-crds.feature:
- Manage fully compatible schema (Avro) - demonstrates Full compatibility level
- Manage product schema (Avro) - prerequisite for schema references example
- Manage order schema with references (Avro) - demonstrates schema references

Add new scenarios to topic-crds.feature:
- Manage topic with write caching - demonstrates write.caching configuration
- Manage topic with cleanup policy - demonstrates cleanup.policy configuration

These examples will be referenced in docs PR #1650:
redpanda-data/docs#1650

Fixes from CodeRabbit review:
- Added prerequisite product-schema before order-schema to ensure
  referenced schema exists
- Named delete-policy-topic appropriately to match cleanup.policy: "delete"
@JakeSCahill
Copy link
Copy Markdown
Contributor

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 13, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@JakeSCahill JakeSCahill merged commit 57280ac into redpanda-data:main Apr 13, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants