Repository navigation
Conversation
createCaseworkItem forwards an optional resultConstraints object verbatim for server-side validation and keeps the create request closed when it is absent; server constraint diagnostics pass through the bounded validation allowlist. pollCaseworkResults surfaces the structured result on completed items exactly as returned and tolerates servers that omit it. Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bc3e98830e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| createCaseworkRequest: (options = {}) => | ||
| operation(loadBindings, options, "caseworkCreated", null, (client, auth, input) => | ||
| client.createHostedItem( | ||
| client.createOrRecoverReviewRequest( |
There was a problem hiding this comment.
With a fresh install from the committed manifest and lockfile, @registrystack/client remains at published version 0.32.0, while native.test.js explicitly detects that this version lacks createOrRecoverReviewRequest and skips the integration tests. Consequently this call is undefined and is converted into a generic operation.failed result before any HTTP request is sent; the other newly introduced review methods have the same compatibility problem. Pin and lock the coordinated client release that supplies these methods rather than masking the incompatibility with skipped tests.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Confirmed. The published 0.32.0 package does not implement these methods, so this is blocking rather than a test-only limitation. I am holding this PR from merge. The coordinated immutable client release and repin are tracked in registrystack/registry-stack#1190; once that release exists, this PR must update its manifest/lockfile, remove the native-test skip, and pass the installed-client routes before merge.
|
Superseded by #12 (merged 1 Oct), which carries this unified Casework review lifecycle work against the published client. The Codex P1 thread here (pin a client release that implements the review methods) is already fixed on main: the client is pinned to a published release that supplies them and the native-test skip is gone. |
Summary
Checks
origin/mainimmediately before pushNotes
DCO
Signed-off-bytrailer.