Skip to content

Support Studio review, action dates, and workflow timing - #2630

Open
jeremi wants to merge 8 commits into
mainfrom
feat/studio-product-gaps
Open

jeremi wants to merge 8 commits into
mainfrom
feat/studio-product-gaps

Conversation

@jeremi

@jeremi jeremi commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

Changes

  • Casework can offer different outcomes at each review stage. Omitted lists keep the policy defaults.
  • BReg adds signed whole-day offsets to currentDate, deterministic Rhai date helpers, and a fixed evaluation date for bregctl project action-test. Request audit records identify verifier-matched OAuth clients with an activation-scoped pseudonym.
  • Coordinator can route exhausted, definite availability failures on reads and evaluations. The route receives no step output. It can also route a waiting run once at an elapsed service deadline and admit monthly workflows on the first or last day in a named time zone.
  • The BReg, Coordinator and Casework: hold a submitted request for review until the steps before the review are done #2623 test proves owning-run and exact-version fencing with real Coordinator admission and a simulated release. Production hold and release, and automated Proposal decisions (BReg: accept a decision recorded by a trusted automated decider, with audit #2621), remain separate work.

The stage-specific outcomes in #2617 are implemented. Resuming directly at a later stage after correction remains open. A revised submission starts a fresh round so earlier stages can assess the revised material.

Closes #2486
Closes #2620
Closes #2622
Closes #2624
Closes #2625
Closes #2626

Security and deployment

Client attribution uses the identity matched by the existing verifier. Uncertain effects and authorization refusals retain their existing recovery behavior. A settled result observed at the service deadline takes its ordinary route. Calendar admission uses the pinned definition and a durable cursor under the existing admission fence.

Coordinator uses protected state schema v6. Existing v5 namespaces require draining with the matching version and activation into a fresh namespace.

The dependency commit pins rusqlite 0.41.1 with bundled SQLite 3.54.1 and rmcp 3.9.0 to resolve the two Cargo deny failures. SQLite installs and resets its hooks through an exclusive borrow of the checked-out connection. The Evidence consumer tests exercise the read-only, budget, and cleanup boundary. SQLite advisory, MCP advisory.

Verification

  • Casework core, CLI, client and real PostgreSQL review tests.
  • BReg unit, CLI and real PostgreSQL audit, immediate-commit and Proposal Apply tests. The existing libc collation test requires the Linux locale used by CI.
  • Coordinator authoring, retry, deadline, admission, deployment and recovery tests on disposable PostgreSQL. Calendar coverage includes replica contention, restart, missed occurrences and schedule revision changes.
  • Regenerated schemas and CLI catalog, with contract, formatting and disclosure checks.
  • Cargo deny 0.19.8, SQLite platform and MCP compatibility suites, Evidence SQLite tests run serially, and the standalone SQLite fuzz build. The identifier catalog reproduced byte for byte and the Registry Record artifact check passed.

Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Route exhausted availability failures without exposing an operation output. Check and persist one-time service deadline routes and monthly calendar admissions under the existing workflow and database fences.

Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Keep one trusted evaluation date per action, support signed day offsets and pure plan date helpers, and record the verifier-matched client beside the principal in request audit.

Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
@jeremi
jeremi marked this pull request as ready for review November 9, 2026 19:23
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: 🔄 Running

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-11-09T19:24:02.459707Z 17d7209 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment