Repository navigation
feat: run BReg and Casework together with rstack dev - #2637
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6a5534d850
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2476d26bc7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f9a24ee8a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e7be3ad77d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 50076deed9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
0990c08 to
9e397c0
Compare
|
Review fixes on top of the original change, rebased onto
Checks on the final head: format and clippy for Deferred to follow-up issues: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9e397c047e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
…ants Send product tool and runtime output to owner-only logs under the run directory and append the log tail to startup failures. Record child process groups in processes.json. Refuse unknown BReg grant profiles at their pointer and encrypted fields before provisioning. Read Casework access profiles from the top-level accessProfiles of caseworkctl explain. Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
…ns distinctly Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
…st supervisor with recovery facts Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
…PostGIS and URL refusals Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
9e397c0 to
07cc405
Compare
|
The "Registry Adapter product contracts" job failed on the config-conventions lint, and all of its findings came from the review commits. This push fixes them in those commits:
Checks on this head: the config-conventions lint (0 unrecorded, 0 stale), the identifier catalog check, |
Also reports plan refusals under breg.project-dev.invalid-plan, the code bregctl already uses for the same class. Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
…n's components Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
…sor recovery in the dev acceptance run Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
…sees it half-deleted Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
…ehind Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
…deletion in the dev guide Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
…orkctl explain reports Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
… declare Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
…grant remedy to Casework dev check now inspects the products, so an encrypted BReg field is refused at the product's plan pointer instead of as an unlocated plan error. The BReg grant remedy uses the same wording as the Casework one, and the guide says check refuses grants, bindings and encrypted fields as start does. Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
…variables are set Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
07cc405 to
13a5ce5
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13a5ce5fe1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The local issuer caps each token at five minutes, but `rstack dev token` reported the run's expiry as the tokens' own, so a client that refreshed on that time kept sending expired tokens. The report and the issuer now share one expiry rule. Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
A step's captures are all read from its own response, so a `find` capture whose `where` value used a sibling capture passed validation and then failed at run time. Validation now makes a step's captures available only to later steps. Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
A binding requests tokens for the other product's audience as an OAuth resource, and the products accept that resource only as an absolute URI. A bare audience such as `review` passed `rstack dev check` and failed when the product loaded its configuration. Validation now refuses it at the audience's plan pointer. Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Stop waited for every open token request to finish, so a client that sent headers and never finished its body held `rstack dev stop` forever. The server now gets two seconds to drain, then open requests are dropped. Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
A journey run spends about 200 ms building its client before the first request, and the poll tests allowed 300 ms per poll inside a 500 ms server window, so an occasional stall failed them. The budgets are now one second inside a two-second window; the late body still arrives after the deadline. Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
|
Review round on the four Codex findings: all four fixed, one commit each, threads answered and resolved. One more change, not from a thread: Local checks on the pushed head: the dev runner gates (fmt, clippy |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 019563b493
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
BReg and Casework request a binding identity's grant scopes through the shared OAuth client, which refuses quoted or backslashed scopes and lists longer than 4096 bytes at startup. rstack dev check accepted both, so the run failed after provisioning. The binding check now applies the same shared predicate and reports the grant's scopes pointer. Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
What changed
rstack dev start,status,token, andstopfor isolated project runs. The launcher delegates through the verified toolset and keeps its bootstrap dependency boundary.dev.yamlbefore allocating resources. Use the ordinary BReg and Casework activation paths on supplied TLS PostgreSQL, with run-local keys, database roles, loopback endpoints, and bounded journeys.Verification
Implements #2635.