Skip to content

feat(render): e2e test for vite and nextjs#2176

Open
gabrielmfern wants to merge 36 commits intocanaryfrom
feature/react-22-make-integration-test-for-render
Open

feat(render): e2e test for vite and nextjs#2176
gabrielmfern wants to merge 36 commits intocanaryfrom
feature/react-22-make-integration-test-for-render

Conversation

@gabrielmfern
Copy link
Copy Markdown
Member

@gabrielmfern gabrielmfern commented Apr 21, 2025

This PR adds in a new directory and test file, following the same lines of what we already have with Tailwind. The biggest difference is that the test this PR adds also tests things from the browser with playwright and tries to ensure they don't error during render.

It currently tests with the following:

  • vite in the browser
  • nextjs in the browser
  • nextjs in a node api route
  • nextjs in a edge api route

Where all of them are ran both in dev and in production to make sure it works the same

The test CI is failing exactly because there are two current issues with render, #1630 and #1953. Closes DEV-22

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 21, 2025

🦋 Changeset detected

Latest commit: 45bbb38

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@react-email/render Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-email Ready Ready Preview, Comment May 8, 2026 9:29pm
react-email-demo Ready Ready Preview, Comment May 8, 2026 9:29pm

Request Review

@gabrielmfern gabrielmfern marked this pull request as draft April 21, 2025 17:46
@gabrielmfern gabrielmfern force-pushed the feature/react-22-make-integration-test-for-render branch from 0f8ec1b to 1442a04 Compare April 23, 2025 11:46
@gabrielmfern gabrielmfern force-pushed the feature/react-22-make-integration-test-for-render branch from 1442a04 to b8e1638 Compare April 23, 2025 13:07
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 32 files

Confidence score: 5/5

  • This PR looks low risk to merge: the only finding is a low-severity (2/10) test-description wording issue, with no runtime or user-facing behavior impact.
  • The issue is limited to naming conventions in packages/render/e2e/integrations.spec.ts (use of the forbidden word should in test titles), so it is primarily a style/compliance cleanup.
  • Pay close attention to packages/render/e2e/integrations.spec.ts - update test descriptions to satisfy the no-should convention.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/render/e2e/integrations.spec.ts">

<violation number="1" location="packages/render/e2e/integrations.spec.ts:118">
P3: Custom agent: **No `should` in tests**

Test descriptions use the forbidden word `should` multiple times.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment thread packages/render/e2e/integrations.spec.ts
Signed-off-by: Gabriel Miranda <gabriel@resend.com>
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 1 file (changes from recent commits).

Requires human review: Auto-approval blocked by 1 unresolved issue from previous reviews.

Signed-off-by: Gabriel Miranda <gabriel@resend.com>
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 1 file (changes from recent commits).

Auto-approved: PR adds e2e test infrastructure for render with Vite and Next.js. Changes are limited to test files, test project scaffolding, CI configuration, and dev dependencies. No source code modifications to

Signed-off-by: Gabriel Miranda <gabriel@resend.com>
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 1 file (changes from recent commits).

Auto-approved: Adding e2e tests for render across Vite and Next.js in dev and production. All changes are test infrastructure, CI setup, and boilerplate project files. No production logic modified. Low risk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants