feat(render): e2e test for vite and nextjs#2176
feat(render): e2e test for vite and nextjs#2176gabrielmfern wants to merge 36 commits intocanaryfrom
Conversation
🦋 Changeset detectedLatest commit: 45bbb38 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
0f8ec1b to
1442a04
Compare
1442a04 to
b8e1638
Compare
Signed-off-by: Gabriel Miranda <gabriel@resend.com>
Signed-off-by: Gabriel Miranda <gabriel@resend.com>
Signed-off-by: Gabriel Miranda <gabriel@resend.com>
Signed-off-by: Gabriel Miranda <gabriel@resend.com>
There was a problem hiding this comment.
1 issue found across 32 files
Confidence score: 5/5
- This PR looks low risk to merge: the only finding is a low-severity (2/10) test-description wording issue, with no runtime or user-facing behavior impact.
- The issue is limited to naming conventions in
packages/render/e2e/integrations.spec.ts(use of the forbidden wordshouldin test titles), so it is primarily a style/compliance cleanup. - Pay close attention to
packages/render/e2e/integrations.spec.ts- update test descriptions to satisfy the no-shouldconvention.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/render/e2e/integrations.spec.ts">
<violation number="1" location="packages/render/e2e/integrations.spec.ts:118">
P3: Custom agent: **No `should` in tests**
Test descriptions use the forbidden word `should` multiple times.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Signed-off-by: Gabriel Miranda <gabriel@resend.com>
Signed-off-by: Gabriel Miranda <gabriel@resend.com>
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Auto-approved: PR adds e2e test infrastructure for render with Vite and Next.js. Changes are limited to test files, test project scaffolding, CI configuration, and dev dependencies. No source code modifications to
Signed-off-by: Gabriel Miranda <gabriel@resend.com>
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Auto-approved: Adding e2e tests for render across Vite and Next.js in dev and production. All changes are test infrastructure, CI setup, and boilerplate project files. No production logic modified. Low risk.
This PR adds in a new directory and test file, following the same lines of what we already have with Tailwind. The biggest difference is that the test this PR adds also tests things from the browser with playwright and tries to ensure they don't error during render.
It currently tests with the following:
vitein the browsernextjsin the browsernextjsin a node api routenextjsin a edge api routeWhere all of them are ran both in dev and in production to make sure it works the same
The
testCI is failing exactly because there are two current issues withrender, #1630 and #1953. Closes DEV-22