fix: CDNFileAssetLoader use-after-free when RiveFile deallocates during download#449
Open
mfazekas wants to merge 1 commit into
Open
fix: CDNFileAssetLoader use-after-free when RiveFile deallocates during download#449mfazekas wants to merge 1 commit into
mfazekas wants to merge 1 commit into
Conversation
mfazekas
force-pushed
the
fix/cdn-loader-use-after-free
branch
9 times, most recently
from
562fb9c to
a5264cf
Compare
…ng download RiveFile now cancels in-flight CDN downloads in dealloc before C++ objects are freed. CDNFileAssetLoader tracks NSURLSessionTasks and exposes cancelPendingDownloads, called via FallbackFileAssetLoader from RiveFile.dealloc. Fixes rive-app#448, fixes rive-app#434
mfazekas
force-pushed
the
fix/cdn-loader-use-after-free
branch
from
a5264cf to
ea0bd15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #448, fixes #434
RiveFile.deallocnow cancels in-flight CDN downloads before C++ objects are freed.CDNFileAssetLoadertracks activeNSURLSessionTasks and exposescancelPendingDownloads, fulfilling the existing TODO in the code.Added
CDNFileAssetLoaderTest— tests crash without the fix, pass with it.