Skip to content

chore: bump Nitro Modules to 0.37.1 - #432

Draft
mfazekas wants to merge 1 commit into
mainfrom
chore/nitro-0.37
Draft

mfazekas wants to merge 1 commit into
mainfrom
chore/nitro-0.37

Conversation

@mfazekas

Copy link
Copy Markdown
Collaborator

Bumps nitrogen and react-native-nitro-modules to 0.37.1 (root and all example apps) and regenerates nitrogen/generated. The 0.37 view codegen diffs old/new props via nitro::ReactProp and ViewComponentDescriptor, which don't exist in 0.36, so the peer range moves to >=0.37.1 <0.38 (0.37.0 is skipped because it broke static frameworks, margelo/nitro#1520).

  1. scripts/nitrogen-postprocess.ts: dropped the force-apply-on-recreated-view (fix(ios): blank RiveView after Fabric recreates the component view (react-freeze) — props skipped by consumed isDirty flags #365), RN < 0.85 JSI props parser and _props default-init patches, since 0.37 generates all three itself. Ported the null-for-optional-props patch to the new ReactProp shape (Error when assigning undefined to optional view property margelo/nitro#1184 is still open).
  2. Breaking for consumers: apps must be on react-native-nitro-modules 0.37.1+.
  3. Blocker: iOS on RN <= 0.83 without use_frameworks! fails to compile the NitroModules pod on 0.37.x (iOS build fails since 0.37.0 without use_frameworks! on RN <= 0.83: import of module 'glog.glog.log_severity' appears within namespace 'google' — could not build module 'NitroModules' margelo/nitro#1573, fix in fix: Hide React renderer headers from the Swift-facing NitroModules module margelo/nitro#1575). This hits the bare example/ (RN 0.80). The expo57 CI build (RN 0.86) is not affected.

Regenerate nitrogen output with 0.37.1. The generated view code now uses
nitro::ReactProp and ViewComponentDescriptor from react-native-nitro-modules
0.37, so the peer range moves to >=0.37.1 <0.38.

Drop the postprocess patches that 0.37 makes redundant (force-apply props on
a recreated view, JSI props parser on RN < 0.85, _props default init) and
port the null-for-optional-props patch to the ReactProp shape.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant