Repository navigation
Conversation
Regenerate nitrogen output with 0.37.1. The generated view code now uses nitro::ReactProp and ViewComponentDescriptor from react-native-nitro-modules 0.37, so the peer range moves to >=0.37.1 <0.38. Drop the postprocess patches that 0.37 makes redundant (force-apply props on a recreated view, JSI props parser on RN < 0.85, _props default init) and port the null-for-optional-props patch to the ReactProp shape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
nitrogenandreact-native-nitro-modulesto 0.37.1 (root and all example apps) and regeneratesnitrogen/generated. The 0.37 view codegen diffs old/new props vianitro::ReactPropandViewComponentDescriptor, which don't exist in 0.36, so the peer range moves to>=0.37.1 <0.38(0.37.0 is skipped because it broke static frameworks, margelo/nitro#1520).scripts/nitrogen-postprocess.ts: dropped the force-apply-on-recreated-view (fix(ios): blank RiveView after Fabric recreates the component view (react-freeze) — props skipped by consumed isDirty flags #365), RN < 0.85 JSI props parser and_propsdefault-init patches, since 0.37 generates all three itself. Ported the null-for-optional-props patch to the newReactPropshape (Error when assigningundefinedto optional view property margelo/nitro#1184 is still open).react-native-nitro-modules0.37.1+.use_frameworks!fails to compile theNitroModulespod on 0.37.x (iOS build fails since 0.37.0 withoutuse_frameworks!on RN <= 0.83: import of module 'glog.glog.log_severity' appears within namespace 'google' — could not build module 'NitroModules' margelo/nitro#1573, fix in fix: Hide React renderer headers from the Swift-facing NitroModules module margelo/nitro#1575). This hits the bareexample/(RN 0.80). The expo57 CI build (RN 0.86) is not affected.