Open
Conversation
mergify
bot
requested review from
a team,
gitanshu and
maliesa96
and removed request for
a team
ryanjulian
approved these changes
Oct 29, 2020
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2161 +/- ##
==========================================
- Coverage 91.51% 91.31% -0.21%
==========================================
Files 197 198 +1
Lines 10864 10944 +80
Branches 1370 1374 +4
==========================================
+ Hits 9942 9993 +51
- Misses 666 691 +25
- Partials 256 260 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yeukfu
approved these changes
Nov 4, 2020
Contributor
|
@Mergifyio refresh |
Contributor
|
Command
|
krzentner
approved these changes
Nov 9, 2020
Contributor
krzentner
left a comment
krzentner
left a comment
There was a problem hiding this comment.
Please apply Ruofu's fix. Besides that, this change looks good.
Contributor
|
@Mergifyio refresh |
Contributor
|
Command
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To close #2016 .