Repository navigation
fix(test): use the shared 50MB exec helper in every e2e test - #768
Merged
Merged
Conversation
Fixtures recorded on 2026-07-10 crossed the 90-day expiry on Oct 8. With expiryStrategy=warn, every replayed request from an expired recording prints a full request/response blob to stderr, and `frodo theme import --all-separate` replays enough requests to exceed Node's 1MB default child_process maxBuffer. theme-import.e2e.test.js built its own `promisify(cp.exec)` instead of the shared helper (50MB) and failed with `RangeError: stderr maxBuffer length exceeded`, blocking the 5.0.0-4 release run. Export `exec` from test/e2e/utils/TestUtils.js and switch the 122 e2e test files that defined their own bare `promisify(cp.exec)` over to it, so the next batch of fixtures to age out cannot trip the same limit. session.e2e.test.js (local-only `node -e` seeding, no network) and npm-entry.smoke.e2e.test.js (no Polly traffic) are intentionally unchanged. Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unblocks the 5.0.0-4 release run (
Test (26)failed:theme-import.e2e.test.js→RangeError: stderr maxBuffer length exceeded).Cause. The theme fixtures were recorded 2026-07-10 and crossed the 90-day expiry on Oct 8 (the previous CI runs on Oct 7 passed on identical code). Expiry is
warn-only, but each replayed request from an expired recording prints a full request/response blob to stderr, andfrodo theme import --all-separatereplays enough requests to exceed Node's 1 MB defaultchild_processbuffer.theme-import.e2e.test.jsused its ownpromisify(cp.exec)rather than the shared helper inTestUtils.js(50 MB).Fix. Export
execfromtest/e2e/utils/TestUtils.jsand switch the 122 e2e files that defined their own barepromisify(cp.exec)to it, so the next batch of aging fixtures can't trip the same limit (124 of 261 files had the pattern). Intentionally unchanged:session.e2e.test.js(localnode -eseeding, no network) andnpm-entry.smoke.e2e.test.js(no Polly traffic).No source, fixture, export, or snapshot changes — test imports only (123 files).
Not addressed here
743 recording dirs are now past the 90-day mark. They stay quiet only because of the larger buffer; the noisy expiry warnings will remain until the fixtures are re-recorded against a live tenant (needs credentials —
npm run test:record:cloud).Test plan
theme-import,config-manager-push-terms-and-conditions,sessionpass together (23/23)🤖 Generated with Claude Code