Repository navigation
chore(deps): clear dev-dependency audit findings - #770
Merged
Merged
Conversation
npm audit reports 25 vulnerable package nodes (20 moderate, 5 high) across 2 distinct advisories, all dev-only: braces <= 3.0.3 (via the unused `del` devDependency -> globby -> micromatch; no patched braces exists) and sprintf-js <= 1.1.3 (via js-yaml 3 -> argparse 1 -> sprintf-js; no patched sprintf-js exists). Drop the unused `del` devDependency (no source, test, tool or workflow references it) and add an argparse ^2.0.1 override (argparse 2 has no sprintf-js dependency). npm audit now reports 0 vulnerabilities; Dependabot's 1 open medium alert (sprintf-js) resolves with the lockfile regeneration, and its auto-dismissed braces alert becomes moot. None of the affected packages ship: the package has zero runtime dependencies and none of their code is in the bundle. Lockfile verified with npm@10 and npm@11 `ci --dry-run`; full suite (632 suites / 1824 tests / 8484 snapshots) green with the change. Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm auditin frodo-cli currently reports 25 vulnerable package nodes (20 moderate, 5 high). That number is 2 distinct advisories, all dev-only, counted once per package node that pulls them in:del→ globby → micromatch — no patched braces release exists.delis an unused devDependency: no source, test, tool, script or workflow references it. Dropping it removes the whole chain.js-yaml@3→argparse@1→ sprintf-js — no patched sprintf-js release exists; the fix is avoidingargparse@1(used only by js-yaml's CLI binary, never by library code we import).Change
package.json: remove the unuseddeldevDependency; add"overrides": { "argparse": "^2.0.1" }package-lock.json: regenerated — the entire del/globby/micromatch/braces and argparse/sprintf-js trees are goneResult
npm audit: 0 vulnerabilitiesNot a shipping risk either way
frodo-cli declares zero runtime dependencies; the flagged packages are all in the dev tree and none of their code appears in the built bundle.
Verification
npm@10 ci --dry-runandnpm@11 ci --dry-runaccept the lockfilenpm run checkclean🤖 Generated with Claude Code