Conversation
maelle
requested changes
May 21, 2026
Member
Author
|
@maelle Thanks for the suggestion:
I've made it a separate line now which clearly states that first, followed by the strict requirement of pre-sub. Re-review requested. |
maelle
force-pushed
the
pre-sub
branch
4 times, most recently
from
12c5c09 to
9f1adc3
Compare
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
maelle
reviewed
May 21, 2026
Member
maelle
left a comment
maelle
left a comment
There was a problem hiding this comment.
Thank you! I added the news item and initial translations, let's wait for review.
yabellini
reviewed
May 22, 2026
Member
|
Done Spanish. I already applied my changes. |
Member
Author
|
@yabellini and @maelle : I just added another change - sorry for any inconvenience!! This one will now also need to be translated. Thank you both! |
Member
|
@mpadge this change looks unrelated to the initial PR scope, could you please
Then in that PR I'll add the translations |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ropensci/software-review#767
Checklist for dev guide maintainers, do not delete 😸