Add starting_up_state parameter to Updater#354
Merged
Conversation
ct2034
added
bug
Contributor
Author
|
Hi! Can I get an update on this one? If it wasn't merged because of this test case failing, can I get some help understanding the error? I'm sure a few minutes of someone who already understands these template-based tests can save me hours of trial and error. |
Collaborator
|
Hi @redvinaa.
On the other hand, I also would not like my system starting in an error state. Your issue could also be solved by additional state, such as proposed in ros2/common_interfaces#268. What is your opinion about that? |
ct2034
added
enhancement
Contributor
Author
|
Hi! Sorry for the long delay. It's possible that it would make sense to add new states, but that's a huge change and it appears to be moving very slowly. This PR on the other hand is not breaking, and I think is still useful until the new states get added. |
ct2034
approved these changes
Apr 20, 2026
redvinaa
force-pushed
the
starting-up-state
branch
from
692fd7c to
687c0c4
Compare
ct2034
requested changes
Apr 20, 2026
ct2034
added
the
backport
ct2034
requested changes
Apr 20, 2026
ct2034
added
the
needs more work
Contributor
Author
|
I think the xmllint failure is not coming from this PR (no xml was modified). Otherwise, all requested changes have been addressed. |
ct2034
removed
the
needs more work
…ros#551) The previous implementation is using a callback that is invoked for all the parameter events of all ROS 2 nodes and it filters by node name. It could lead to race conditions when setting parameters depending on the depth size of the callback. With this new approach, the callback is only triggered when setting parameters for the analyzers node, avoiding possible race conditions when setting the parameters. Co-authored-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
ct2034
added a commit
that referenced
this pull request
May 20, 2026
* Add starting_up_state parameter to Updater * Lint * Change to unsigned char * Remove condition * Fix example relative path (#550) * Implement onParametersSet for handling only analyzers node parameters (#551) The previous implementation is using a callback that is invoked for all the parameter events of all ROS 2 nodes and it filters by node name. It could lead to race conditions when setting parameters depending on the depth size of the callback. With this new approach, the callback is only triggered when setting parameters for the analyzers node, avoiding possible race conditions when setting the parameters. * Get rid of deprecated rclcpp::spin_some() (#563) * -Wreorder --------- (cherry picked from commit 60232a7) Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> Co-authored-by: Vince Reda <60265874+redvinaa@users.noreply.github.com> Co-authored-by: Noel Jiménez García <noel.jimenez.gar@gmail.com> Co-authored-by: Christian Henkel <christian.henkel2@de.bosch.com> Co-authored-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com>
ct2034
added a commit
that referenced
this pull request
May 20, 2026
* Add starting_up_state parameter to Updater * Lint * Change to unsigned char * Remove condition * Fix example relative path (#550) * Implement onParametersSet for handling only analyzers node parameters (#551) The previous implementation is using a callback that is invoked for all the parameter events of all ROS 2 nodes and it filters by node name. It could lead to race conditions when setting parameters depending on the depth size of the callback. With this new approach, the callback is only triggered when setting parameters for the analyzers node, avoiding possible race conditions when setting the parameters. * Get rid of deprecated rclcpp::spin_some() (#563) * -Wreorder --------- (cherry picked from commit 60232a7) Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> Co-authored-by: Vince Reda <60265874+redvinaa@users.noreply.github.com> Co-authored-by: Noel Jiménez García <noel.jimenez.gar@gmail.com> Co-authored-by: Christian Henkel <christian.henkel2@de.bosch.com> Co-authored-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com>
ct2034
added a commit
that referenced
this pull request
May 20, 2026
* Add starting_up_state parameter to Updater * Lint * Change to unsigned char * Remove condition * Fix example relative path (#550) * Implement onParametersSet for handling only analyzers node parameters (#551) The previous implementation is using a callback that is invoked for all the parameter events of all ROS 2 nodes and it filters by node name. It could lead to race conditions when setting parameters depending on the depth size of the callback. With this new approach, the callback is only triggered when setting parameters for the analyzers node, avoiding possible race conditions when setting the parameters. * Get rid of deprecated rclcpp::spin_some() (#563) * -Wreorder --------- (cherry picked from commit 60232a7) Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> Co-authored-by: Vince Reda <60265874+redvinaa@users.noreply.github.com> Co-authored-by: Noel Jiménez García <noel.jimenez.gar@gmail.com> Co-authored-by: Christian Henkel <christian.henkel2@de.bosch.com> Co-authored-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current implementation, when the Updater object is constructed, it sends off an "OK" signal. This could be problematic if we consider "Everything is running as expected" (definition of "OK" status as per REP107), that running is already initialized.
The default behavior doesn't change with this PR, so it wouldn't break anything.
Also, in the python implementation, None can be passed to skip "Node starting up" status publishing altogether.