Repository navigation
Build(deps): Bump golang.org/x/sys from 0.49.0 to 0.50.0 in /cmd/agentop - #1754
dependabot[bot] wants to merge 2 commits into
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
clawgenti
left a comment
There was a problem hiding this comment.
Summary
This is a routine Dependabot minor bump of golang.org/x/sys from v0.49.0 to v0.50.0 in cmd/agentop. The dependabot-tidy commit (42435d4) carries the same bump into scripts/readme-demo, which pulls in agentop through a replace. The diff touches only go.mod and go.sum (4 files, +6/-6). The new h1: hashes match sum.golang.org. No must-fix issues found.
Author: dependabot[bot] (CONTRIBUTOR, trusted automated dependency bot)
Areas reviewed: Go module manifests (go.mod/go.sum), module graph consistency, supply chain
Agent/IDE config (.claude/.vscode): none
Commits: 2 commits (the bump plus the dependabot-tidy chore: go mod tidy across modules), all signed-off: yes (DCO pass)
CI status: pending. On head 42435d4 only DCO has passed so far: 1 pass, 0 fail, 35 pending, and 3 skipped (CodeRabbit, Spellcheck, and the tidy job, which correctly found nothing left to do). The CI, Security Scans, Build-Publish and PR Verifier runs are still queued. Before the tidy commit, the run on 1770722 had no failures. Please confirm CI goes green before merging.
Upstream / transitive check
- go directive: x/sys v0.50.0's
go.moddeclaresgo 1.26.0and has norequireblock, the same as v0.49.0.cmd/agentopandscripts/readme-demoboth declarego 1.26.10, so that's fine. - Transitive requirements: none. The
/go.modhashhNLxWAXm…is the same in v0.49.0 and v0.50.0, which is why the go.sum delta is limited to the x/sys lines. - go.sum:
h1:dkKZEFTE…and/go.mod h1:hNLxWAXm…match sum.golang.org (tree 71041460). I also rebuilt the module zip from thev0.50.0tag (00227f1d) and got the sameh1:. - Upstream changes (10 commits): mostly Windows (
SyscallN,mkwinsyscall, PSAPI accessors, removal ofMemoryBasicInformation.PartitionIdon windows/386), pluscpu: wasm32,unix: ppc64x R12,IoctlGetUint64, and a freebsd/386 sendfile fix. Two Linux behavior changes:ParseDirentno longer skips zero-inode entries on Linux.ParseUnixCredentialsnow rejects a shortSCM_CREDENTIALSpayload withEINVAL.
- Repo usage: agentop only calls
unix.Getsid(insetup_probe_test.go). Across the repo, theunixuses areGetsockoptUcred/GetsockoptXucred,UnixRights/ParseUnixRights,SysctlRaw,SysctlKinfoProc,Syscall6and similar. Nothing callsParseDirent,ParseUnixCredentials, orx/sys/windows, and no API the repo uses was removed or changed. - replace / siblings:
cmd/agentopreplacescore => ../../core, andcorestays on v0.49.0, so MVS selects v0.50.0 for agentop and readme-demo. That's valid. Locally (Go 1.26.10,GOWORK=off,-mod=readonly) every module builds at the head SHA: core, core/storage/redis, cmd/agentop, cmd/cortex (local profile tags), cmd/cortex-envoy, and scripts/readme-demo.go vet ./...(linux and darwin) andgo test ./...pass for readme-demo. They also pass for agentop, exceptTestReportSessionInterruption, which fails the same way onmainin my sandbox and is unrelated to this bump.
Nit (non-blocking): core and the rest of the modules still list x/sys v0.49.0. The sibling #1753 bumps core, and that PR's tidy moves all modules to v0.50.0, so the two PRs line up whichever merges first.
clawgenti
left a comment
There was a problem hiding this comment.
Summary
This is a routine Dependabot minor bump of golang.org/x/sys from v0.49.0 to v0.50.0 in cmd/agentop. The dependabot-tidy commit (42435d4) carries the same bump into scripts/readme-demo, which pulls in agentop through a replace. The diff touches only go.mod/go.sum (4 files, +6/-6). No must-fix issues found.
Author: dependabot[bot] (CONTRIBUTOR, returning external)
Areas reviewed: Go module manifests (go.mod/go.sum), module graph consistency, supply chain
Agent/IDE config (.claude/.vscode): none
Commits: 2 commits, all signed-off: yes (DCO pass)
CI status: passing on head 42435d4: 37 pass, 0 fail, 3 skipped (CodeRabbit, Spellcheck, and the tidy job, which had nothing left to do). This includes Go CI (authbridge agentop), Go CI (README demo), Verify module graph is tidy, Dependency Review and Trivy Filesystem Scan.
Verification (local, Go 1.26.10, GOWORK=off)
- go.sum integrity:
golang.org/x/sys v0.50.0 h1:dkKZEFTE…and/go.mod h1:hNLxWAXm…match the sum.golang.org record (tree 71041460).go mod verifypasses in both modules. The/go.modhash is the same as v0.49.0's (x/sys has no requirements), so no other go.sum lines changed. - Tidiness:
go mod tidy -diffis empty forcmd/agentopandscripts/readme-demoat head. - Build/vet:
go build ./...andgo vet ./...(linux andGOOS=darwin) succeed for both modules with-mod=readonly, andgo list -mresolvesgolang.org/x/sys v0.50.0. - Tests:
scripts/readme-demopassesgo test ./.... Incmd/agentop, all packages pass except three tests that also fail onmainin my sandbox (no systemd user bus, a sandbox network proxy) or are timing-flaky (TestTrunc_ScalesLinearly, which passes on rerun). None of them are related to this bump, and the CI agentop job is green. - API impact: agentop only uses
unix.Getsid, and nothing the repo calls from x/sys was removed or changed in v0.50.0.
Nit (non-blocking): core and the other modules remain on x/sys v0.49.0. Sibling #1753 bumps core, and the tidy step on whichever PR merges second will reconcile the rest.
Verdict note: The diff is clean. Under the review policy, though, PRs from non-maintainer authors (dependabot's association here is CONTRIBUTOR) are not auto-approved. A maintainer should give the final approval.
Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.49.0 to 0.50.0. - [Commits](golang/sys@v0.49.0...v0.50.0) --- updated-dependencies: - dependency-name: golang.org/x/sys dependency-version: 0.50.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
42435d4 to
6d5f5c5
Compare
Auto-tidied by dependabot-tidy workflow to keep cmd/* go.sum files in sync with core after a Dependabot bump. Signed-off-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps golang.org/x/sys from 0.49.0 to 0.50.0.
Commits
00227f1unix: avoid using stale written count from sendfile on freebsd/386 after EINVALaa1b965unix: don't skip directory entries with zero inodes on Linux37845fbunix: reject a short SCM_CREDENTIALS payload in ParseUnixCredentials313c631unix: add IoctlGetUint644a36a34cpu: add wasm32 "architecture"908ab59windows: use SyscallN consistently for Windows system callsf5cb030unix: set R12 before the ppc64x syscall branch0e9e10fwindows: remove MemoryBasicInformation.PartitionId field on windows/3869b24ac0windows: fix PSAPI_WORKING_SET_EX_BLOCK bit accessors69a6691windows/mkwinsyscall: read 32-bit results from the low half of the return reg...