Repository navigation
feat: Release cortex-gateway as a standalone binary #1773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
huang195
merged 11 commits into
rossoctl:main
from
huang195:feat/praxis-release-1723-pP1
Nov 10, 2026
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
bf92857
docs: Add the plan for the cortex-gateway release (#1723)
huang195 b3a9fc0
docs: Fix the plan dependencies and build details for #1723
huang195 02bbf08
feat: Add the cortex-gateway release build and linkage check
huang195 4ebe2a1
fix: Remove the old gateway binary before the build copies a new one
huang195 053bc2a
feat: Build cortex-gateway in the release workflow
huang195 0f133b0
ci: Build cortex-gateway weekly against the latest Praxis
huang195 aee5334
docs: Describe the cortex-gateway release build
huang195 4d1a7f9
fix: Keep the smoke test when a gateway leg fails
huang195 d79ab5e
fix: Fail the weekly Praxis job when its pins do not move
huang195 aa7c578
fix: Do not list gateway platforms in the release notes
huang195 cf14f58
fix: Let Dependabot bump openssl-src for praxis
huang195 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,105 @@ | ||
| # Praxis latest - build cortex-gateway weekly against the newest Praxis release. | ||
| # | ||
| # Moves the praxis-proxy pins to the newest crates.io version, then runs the tests and | ||
| # the static release build. It blocks nothing. On failure, the report job comments on | ||
| # the open "Weekly build against the latest Praxis failed" issue, or opens it. | ||
| # | ||
| name: Praxis latest | ||
|
|
||
| on: | ||
| schedule: | ||
| - cron: "17 6 * * 1" | ||
| workflow_dispatch: | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| build: | ||
| name: Build against the latest Praxis | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 90 | ||
| env: | ||
| # The same pinned image as build-gateway in release-binaries.yaml. | ||
| RUST_ALPINE: docker.io/library/rust:1.96.0-alpine@sha256:f87aa870663e2b57ec8c69de82c7eedf7383bee987eef7612c0359635eaadb41 | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| with: | ||
| persist-credentials: false | ||
|
|
||
| # crates.io refuses a request with no User-Agent. | ||
| - name: Resolve the newest Praxis version | ||
| id: praxis | ||
| run: | | ||
| set -euo pipefail | ||
| v=$(curl -fsSL -A "rossoctl-cortex-ci (github.com/rossoctl/cortex)" \ | ||
| https://crates.io/api/v1/crates/praxis-proxy | jq -r .crate.max_stable_version) | ||
| if ! printf '%s\n' "$v" | grep -qE '^[0-9]+\.[0-9]+\.[0-9]+$'; then | ||
| echo "::error::crates.io gave no usable praxis-proxy version: '$v'" | ||
| exit 1 | ||
| fi | ||
| pinned=$(sed -n -E 's/^praxis-proxy = \{ version = "=([0-9.]+)".*/\1/p' praxis/server/Cargo.toml) | ||
| echo "Pinned Praxis: ${pinned}. Newest Praxis: ${v}." | ||
| echo "version=${v}" >> "$GITHUB_OUTPUT" | ||
|
|
||
| - name: Move the Praxis pins | ||
| env: | ||
| PRAXIS_VERSION: ${{ steps.praxis.outputs.version }} | ||
| run: | | ||
| set -euo pipefail | ||
| v="${PRAXIS_VERSION}" | ||
| sed -i -E 's/^(praxis-proxy(-filter)? = \{ version = )"=[0-9.]+"/\1"='"$v"'"/' \ | ||
| praxis/server/Cargo.toml praxis/filters/Cargo.toml | ||
| git diff --stat | ||
| # If sed matched nothing, the job would test the old pin and pass. | ||
| for f in praxis/server/Cargo.toml praxis/filters/Cargo.toml; do | ||
| pins=$(grep -E '^praxis-proxy(-filter)? *=' "$f" || true) | ||
| if [ -z "$pins" ] || printf '%s\n' "$pins" | grep -vqF "\"=${v}\""; then | ||
| echo "::error::${f}: the Praxis pins did not move to =${v}" | ||
| exit 1 | ||
| fi | ||
| done | ||
|
|
||
| # Installs the toolchain that praxis/rust-toolchain.toml names. | ||
| - name: Test | ||
| working-directory: praxis | ||
| run: | | ||
| set -euo pipefail | ||
| rustup toolchain install | ||
| # --recursive: a new Praxis can need newer shared dependencies too. | ||
| cargo update --recursive -p praxis-proxy -p praxis-proxy-filter | ||
| cargo test --locked | ||
|
|
||
| - name: Static release build | ||
| run: | | ||
| set -euo pipefail | ||
| docker run --rm -v "${GITHUB_WORKSPACE}:/src" -w /src -e VERSION=praxis-latest \ | ||
| "${RUST_ALPINE}" sh scripts/build-gateway.sh | ||
|
|
||
| report: | ||
| name: Report a failure | ||
| needs: build | ||
| if: failure() | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 5 | ||
| permissions: | ||
| issues: write | ||
| env: | ||
| GH_TOKEN: ${{ github.token }} | ||
| TITLE: Weekly build against the latest Praxis failed | ||
| steps: | ||
| - name: Comment on or open the issue | ||
| run: | | ||
| set -euo pipefail | ||
| run_url="${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/actions/runs/${GITHUB_RUN_ID}" | ||
| n=$(gh issue list --repo "${GITHUB_REPOSITORY}" --state open \ | ||
| --search "in:title \"${TITLE}\"" --json number --jq '.[0].number') | ||
| if [ -n "$n" ]; then | ||
| gh issue comment "$n" --repo "${GITHUB_REPOSITORY}" --body "Failed again: ${run_url}" | ||
| else | ||
| gh issue create --repo "${GITHUB_REPOSITORY}" --title "${TITLE}" \ | ||
| --body "Failed run: ${run_url} | ||
|
|
||
| This job does not block anything. See the run log for the cause." | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: The gateway tarball changes the install statistics.
scripts/collect-install-stats.shplatform_ofputs every asset name that containslinux_amd64(and the other platforms) into a platform bucket, socortex-gateway_<tag>_linux_amd64.tar.gzcounts as a linux tarball.docs/install-stats/index.htmlthen halves the platform sum withperInstall = 2(cortex + agentop). Aninstall.sh --praxisinstall downloads three tarballs of one platform, so each praxis install counts as 1.5 in the Linux/Mac columns, and the CI subtraction on Linux mixes the two scales. It is not a blocker. A follow-up could givecortex-gateway_*its own bucket inplatform_of(checked before the platform tests), or at least note this next toperInstall.