Repository navigation
feat: List tool calls in agentop's events table with their duration #1778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
huang195
wants to merge
21
commits into
rossoctl:main
Choose a base branch
from
huang195:feat/tool-rows-1776-pP1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,878
−71
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
d91e6af
docs: Add the implementation plan for agentop tool rows (#1776)
huang195 04fdb73
docs: Fix the name clash and vague steps in the tool rows plan
huang195 319bda7
feat: Let a short table row's last cell span the remaining columns
huang195 3c404ef
docs: Say how agentop measures a tool's duration
huang195 9f6068f
feat: Fetch the timeline while the events pane shows a session
huang195 4f78ad9
fix: Drop the old timeline on a session change and on an erase
huang195 b14da0e
feat: Index timeline tools by the response that asked for them
huang195 fef0756
feat: List tool calls in the events table with their duration
huang195 2bc13be
test: Find a tool row by text that no shown column holds
huang195 1bf5869
test: Add tool rows to the events-table rebuild benchmark
huang195 09c4e30
fix: Remove control runes from a tool row's name and preview
huang195 5fe711b
fix: Start the timeline fetch again after Esc from the Agents overlay
huang195 da39709
refactor: Remove the unread eventRow.parent field
huang195 501c7bd
fix: Fetch no timeline for a cached-only session after Esc
huang195 e4e1259
fix: Match a Bash row to its background job by tool ID
huang195 4da7198
fix: Keep the cursor on a tool row whose ID other rows also use
huang195 16e5036
docs: Name the DURATION column in the help line for tool rows
huang195 385456b
fix: Give a Bash job only to the call that started it
huang195 e18d3ef
fix: Fetch no timeline for a cached-only session from the Timeline pane
huang195 9330e7b
fix: Keep the timeline tick chain through a list blip; fit the sorted…
huang195 a6fba43
fix: Fetch a never-fetched timeline on the first tick after its sessi…
huang195 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: A tool with an empty
IDcannot be pinned.pinKeyOfgives{tool: "", toolAgent: "main", toolSeq: N}. Herek.tool == ""takes the event branch, which matches nothing, so the next rebuild (any streamed event) moves the cursor to the top and clears the pin. Some OpenAI-compatible and local models send tool calls with noid, and the parsers pass the emptyIDthrough. A probe showed the cursor go from 1 to 0. Testingk.toolAgent != ""(a tool row always has an agent), or adding an explicitisToolflag toeventKey, avoids this.