Repository navigation
fix(harness): honor the session sandbox tier in /v1/runs - #715
Open
moonlight16 wants to merge 1 commit into
Open
moonlight16 wants to merge 1 commit into
moonlight16 wants to merge 1 commit into
Conversation
Signed-off-by: Jeremy Cohn <Jeremy.Cohn@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /v1/runsignored the session's sandbox tier: knative-server putssandboxTierin theconfig it hands
runLeaf, but the prompt, solve and verdict leaves never passed it toselectPoolSandbox, so every run used the default tier while/v1/turnhonored it. This passesconfig.sandboxTieras the selection tier in all three leaves. A session with no tier isunchanged. A microVM-tier run that names a workload now fails with
workload_sandbox_unavailableinstead of silently running in the container tier, since workload sandboxes are container-only.
Checklist
git commit -s).make lintand the tests for the touched packages pass.docs/page, with the right maturity label (seedocs/CONTRIBUTING-DOCS.md). (n/a: bug fix)make check-linkspasses if any Markdown changed. (n/a)docs/specs/README.mdordocs/adrs/README.md. (n/a)