Repository navigation
docs: combine doc-drift fixes from #14, #15, #16 - #22
Conversation
Automated fix by RepoMan Doc-Drift Fixer (2026-11-05). Signed-off-by: 65532 user <65532@agent-f6a74c71745da212-0.agent-f6a74c71745da212.dam-prod-agents.svc.cluster.local> (cherry picked from commit 6c0b167)
Automated fix by RepoMan Doc-Drift Fixer (2026-11-05). Signed-off-by: 65532 user <65532@agent-f6a74c71745da212-0.agent-f6a74c71745da212.dam-prod-agents.svc.cluster.local> (cherry picked from commit 6b7dc3f)
- Document set-requirements in repoman-setup.sh header subcommand list. - Cite merged PRs rossoctl#12 and rossoctl#9 in the [0.1.1] changelog. Automated update by RepoMan Doc-Drift Fixer (2026-11-05). Signed-off-by: Clawgenti <clawgenti@users.noreply.github.com> (cherry picked from commit 32a0cef)
jimcadden
left a comment
There was a problem hiding this comment.
Verdict: request changes — one blocking item (DCO), everything else is content that verifies.
Blocking: DCO is red, and it is a real sign-off mismatch, not a flake.
The check reports 2 commits incorrectly signed off. The sign-off trailer is present on all three commits, but on ec75e73 and 9d77476 it names the container identity instead of the commit author:
- expected
Clawgenti <clawgenti@users.noreply.github.com> - got
65532 user <65532@agent-f6a74c71745da212-….svc.cluster.local>
0cb4c23 is correct (Clawgenti <clawgenti@users.noreply.github.com>). Fix per the DCO bot's own instructions: git rebase HEAD~3 --signoff then force-push the branch. All three commits are SSH-signed and verify, so a rebase preserves that.
Root cause worth fixing upstream: the two bad trailers came from the doc-drift fixer's cherry-picked commits. A cherry-pick that rewrites the author keeps the original Signed-off-by, so every fixer-authored commit that gets re-attributed later will fail DCO. Signing off at cherry-pick time (git cherry-pick -s) or having the fixer emit the branch author's identity would prevent this recurring.
Correction on my earlier review of #14 and #15 — I approved both on 2026-11-05 saying DCO passed. It did not: those heads (6c0b167, 6b7dc3f) fail the exact same check. I counted Signed-off-by lines instead of validating the email. My mistake, and it is the one thing this combined PR inherits unchanged.
Verified, no action needed:
- The diff is exactly the union of #14, #15 and #16 — same hunks, nothing lost, nothing extra; #14/#15/#16 are already closed as superseded.
- Base is current
main(38f0b1c),mergeable: true, 2 files, +8/−7. - Release dates match the API:
v0.1.1tag 2026-11-05T15:51:59Z / release 15:52:14Z;v0.1.0release created 2026-10-27T19:04:04Z. Both corrections are right. - The two cited PRs really are the
[0.1.1]window: #9 merged 2026-11-02T17:11Z, #12 merged 2026-11-05T12:11Z, both after thev0.1.0release and beforev0.1.1. set-requirementsexists (cmd_set_requirements,repoman-setup.sh:483), is advertised inusage()at :60, andskills/repoman/SKILL.md:34already lists it — only the file header lagged, so the header fix is correct and now consistent.- No
.claude/or.vscode/paths anywhere in the diff. - CI: shellcheck, pr-title-check and add-to-project pass; DCO is the only red.
Two smaller things (body-level, outside the anchorable lines):
CHANGELOG.md:17— “Thev0.1.1tag is cut frommainafter this release merges” is now false:v0.1.1was tagged on 2026-11-05. Since this PR is the one touching the[0.1.1]header, it is a natural place to drop that sentence.- PR body footer says “🤖 Generated with Claude Code”.
CLAUDE.md§ PR Description Attribution asks forAssisted-By: Claude Codeand explicitly says never “Generated by Claude Code” or similar — same convention drift I flagged on the doc-drift-fixer PR bodies; the fix belongs in the fixer's template inrossoctl/automation.
Nothing else blocks. Rebase to fix DCO and this is mergeable as-is.
Generated by RepoMan github-pr-review@235a7f7 (https://github.com/rossoctl/agent-skills/blob/235a7f7620139ee3e4ab0872b8439591fe52e8c1/skills/github-pr-review/SKILL.md).
| # target directory, then `mv` into place, so a crash mid-write never leaves a | ||
| # half-written JSON file). | ||
| # Subcommands: init-config, add-repo, enable-program, set-output, | ||
| # set-requirements. Each writes exactly one thing, validates it, and persists |
There was a problem hiding this comment.
suggestion: this file is in the vendor manifest (_vendor.json lists repoman-setup.sh, source rossoctl/automation@fa619090), so the header now diverges from upstream — and upstream still has the old four-subcommand text at both fa61909 and current main (f509e7a). A future scripts/vendor-engine.sh run will silently revert this fix, the same way enable-program --help keeps coming back.
The change itself is correct and matches skills/repoman/SKILL.md:34. Suggest landing the same one-line header edit in rossoctl/automation/scripts/repoman-setup.sh so it survives the next re-vendor.
|
|
||
| - **doc-drift program.** The scanner and fixer compare documentation to the code at a pinned git ref (paths, flags, enumerations, retired names, versions, and absence claims) and draft Keep a Changelog notes from merged pull requests. It ships inside the `repoman` plugin and as its own marketplace plugin. | ||
| - **doc-drift program.** The scanner and fixer compare documentation to the code at a pinned git ref (paths, flags, enumerations, retired names, versions, and absence claims) and draft Keep a Changelog notes from merged pull requests. It ships inside the `repoman` plugin and as its own marketplace plugin. (#12) | ||
| - **REPOMAN banner** on interactive sessions. (#9) |
There was a problem hiding this comment.
nit (re-raised from #16): "interactive sessions" is broader than what the banner actually does — skills/repoman/SKILL.md § Startup banner prints it on a human /repoman turn and skips schedule/cron, headless -p, pipeline and CI runs. Suggest - **REPOMAN banner** on human /repoman turns. (#9).
| ### Added | ||
|
|
||
| - **doc-drift program.** The scanner and fixer compare documentation to the code at a pinned git ref (paths, flags, enumerations, retired names, versions, and absence claims) and draft Keep a Changelog notes from merged pull requests. It ships inside the `repoman` plugin and as its own marketplace plugin. | ||
| - **doc-drift program.** The scanner and fixer compare documentation to the code at a pinned git ref (paths, flags, enumerations, retired names, versions, and absence claims) and draft Keep a Changelog notes from merged pull requests. It ships inside the `repoman` plugin and as its own marketplace plugin. (#12) |
There was a problem hiding this comment.
suggestion (also from #16): these are the first PR citations in the file — the Shellcheck bullet two lines below has none — so the section is now inconsistent. Either cite every entry and make them links (([#12](https://github.com/rossoctl/repoman/pull/12)); a bare #12 is plain text in Markdown), or cite none and keep the body uniform.
Vendor the engine from rossoctl/automation (feat/stdlib-link-checker, PR rossoctl/automation#123): link-check.py joins the vendored set (scripts/vendor-engine.sh extras + regression-test coverage), and the scanner, extractor, and automation-health dashboard updates land with it. LINK_CHECKER=python is the default, so link-health needs only python3/gh/jq/bash and runs on a basic agent image; egress-proxy refusals are classified as unchecked and never open or auto-close issues. Rewrite the link-health-scanner SKILL.md for the python-default contract (link checker selection, unchecked bucket, shadow mode, .lychee.toml subset) and note the dashboard's unchecked rows. The vendored repoman-setup.sh header reverts the doc-drift fixer's rossoctl#22 edit: vendored bytes must track the engine source, and the set-requirements header fix lands at the source in rossoctl/automation#141 instead. Closes rossoctl#3 Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Jim Cadden <jcadden@ibm.com>
Combines three overlapping doc-drift fixes into one reviewable change. Supersedes #14, #15, and #16.
Release dates
2026-11-04→2026-11-052026-10-23→2026-10-27Changelog citations
#12on the doc-drift program entry.#9REPOMAN banner entry.Setup header
skills/repoman/scripts/repoman-setup.sh— listset-requirementsalongside the other three subcommands.Files touched:
CHANGELOG.md,skills/repoman/scripts/repoman-setup.sh.All three commits are SSH-signed and verify on GitHub.
🤖 Generated with Claude Code