Repository navigation
Conversation
…b-pr-review Mirror of rossoctl/agent-skills#53 for the deployed pr-review program, which is what missed the two must-fix bugs on rossoctl/cortex#1658 and #1659 that motivated the change: - §3.11 Claims Check: verify every fix a PR claims in its exact target case and sibling variants; the new test must assert what the user sees. - §3.12 Behavioral Probes: concrete-case rule (no case, no finding) and opportunistic head-vs-base probes that run only with tooling already on PATH — never installed mid-review. The recipe is self-cleaning (worktree trap) and states its $LOG_DIR precondition. - must-fix is defined positively: the user-visible behavior is wrong. 'Not a regression vs main' does not downgrade it. - The review summary carries an auditable 'Not checked:' list naming what was skipped and why. Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Jim Cadden <jcadden@ibm.com>
Contributor
Author
|
This is a mistake. The github-pr-review skill will be brought over at the vendoring for 0.1.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirrors rossoctl/agent-skills#53 into this repo, where the deployed
pr-reviewprogram lives. The misses that motivated the change (rossoctl/cortex#1658, #1659) came from this copy, so the fix has to land here to take effect; the agent-skills PR keeps the standalone plugin in sync.Adds two behavioral checks to
skills/github-pr-review/SKILL.md:PATH, never install or substitute tools mid-review. The probe recipe is self-cleaning (trap + worktree remove/prune) and states its$LOG_DIRprecondition.must-fixis defined positively — the user-visible behavior is wrong — so a claimed fix that does not hold (§3.11) and input that base handled but head rejects (§3.12) are must-fix even whenmainwas equally broken.Verificationline becomes an auditableNot checked:bullet list naming what was skipped and why (e.g. missing toolchain, which §3.12 forbids installing).Follows the maintainer review on agent-skills#53 and the tracking issue rossoctl/agent-skills#54.
Assisted-By: Claude Code