Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7673fafab3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "@types/node": "^24.12.0", | ||
| "prettier": "^3.8.1", | ||
| "typescript": "^5.9.3" | ||
| "typescript": "6.0.2" |
There was a problem hiding this comment.
Keep TypeScript within declared peer range
Pinning typescript to 6.0.2 puts this repo outside the peer dependency ranges declared by the current toolchain (@rslib/core@0.20.0 and rsbuild-plugin-dts@0.20.0 both require typescript: ^5 in pnpm-lock.yaml), so installs will fail in environments using pnpm --strict-peer-dependencies and non-strict installs run with an explicitly unsupported compiler major. Please either upgrade those build dependencies to versions that support TS 6 or keep TypeScript on v5.x.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
Upgrades the repository’s TypeScript toolchain and aligns the root tsconfig.json with a NodeNext-oriented configuration, updating dependency metadata to reflect the new compiler version.
Changes:
- Bump
typescriptto6.0.2and update lockfile resolution. - Replace root
tsconfig.jsonsettings with a NodeNext-focused configuration (module/moduleResolution, target, rootDir). - Adjust TypeScript dependency specifier to a pinned version.
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tsconfig.json | Switches compiler settings to NodeNext + updates target/rootDir/types. |
| package.json | Pins TypeScript to 6.0.2 in devDependencies. |
| pnpm-lock.yaml | Updates TypeScript resolution (and dependent snapshots) to 6.0.2. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
tsconfig.jsonwith the shared NodeNext configuration.pnpm buildandpnpm test.Related Links