Skip to content

Wait for pager to terminate#1192

Merged
tompng merged 1 commit intoruby:masterfrom
tompng:wait_pager
Mar 27, 2026
Merged

Wait for pager to terminate#1192
tompng merged 1 commit intoruby:masterfrom
tompng:wait_pager

Conversation

@tompng
Copy link
Copy Markdown
Member

@tompng tompng commented Mar 27, 2026

IRB need to wait for pager process termination.
Otherwise, pager process may print some escape sequence or change stdin raw/cooked mode while Reline is reading the next input.

Fix this bug:

irb(main):001> help

Press CTRL-C

irb(main):001> help
^[[11;2R

0.5sec later

irb(main):001> help
irb(main):002> 

This will also fix CI flakiness (ruby/reline#891 (comment))

@st0012 st0012 added the bug Something isn't working label Mar 27, 2026
@tompng tompng merged commit b140bfc into ruby:master Mar 27, 2026
40 checks passed
@tompng tompng deleted the wait_pager branch March 27, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants