Better ripper event tests / handful of compatibility fixes#4032
Merged
Better ripper event tests / handful of compatibility fixes#4032
Conversation
Currently there is just one very basic one.
`::X &&= 1` for example emitted `on_int` twice
They may not be part of `on_param` but ripper still calls `on_ident` for them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the events are not very well tested, now it compares against the full test suite. Also includes a handful of fixes for better compat that I discovered during this.
For the event excludes, most are not implemented at all like
on_commaand others have many failures I didn't check out yet likeon_words_sep. The test excludes are for implemented events that just have a few incompatibilities here and there.Eventually I want to implement currently unimplemented types like
on_tstring_beginwhich yard for example uses. Seems like that should be possible.