Repository navigation
Require Ruby 2.4 or later - #81
Merged
Merged
Conversation
The extension uses RB_INT2FIX, which ruby.h defines only since Ruby 2.4, so it has never built on 2.3. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
A connection left to GC was collected in the middle of a later test, and WMI then cancelled that test's query with WBEM_E_CALL_CANCELLED. When this happened before the first OnObjectReady was dispatched, test_s_new_loop saw only "OnCompleted" and failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
win32ole.gemspecdeclaresrequired_ruby_version >= 2.3.0, but the extension cannot build on Ruby 2.3. It usesRB_INT2FIXin 61 places, andruby.honly defines that macro since Ruby 2.4. This was already the case when win32ole became a gem.I raised
required_ruby_versionto 2.4 and loweredmin_versionin the Windows workflow from 2.6 to 2.4, so CI now tests the declared minimum.This also fixes the flaky
test_s_new_loop, which failed on 2.6 in the first run here with@eventbeing just"OnCompleted". When GC collects the@wmiconnection left by an earlier test while an event delivery is pending, WMI cancels the running query withWBEM_E_CALL_CANCELLED. I release the connection inteardown. Locally the query was cancelled mid-test in 13 of 18 runs before and in none of 7 runs after.Generated with Claude Code