🎨 Palette: Enhanced Search Empty State & Button Accessibility#192
🎨 Palette: Enhanced Search Empty State & Button Accessibility#192ruhdevops wants to merge 4 commits into
Conversation
This change improves the UX of the search functionality by: - Refactoring the "No results found" empty state to use consistent design-system classes (`btn btn-secondary`). - Removing inline 'onclick' handlers in favor of robust event delegation. - Ensuring focus is returned to the search input after clearing results for better keyboard accessibility. - Adding 'aria-hidden' to decorative icons in the empty state. - Fixing a pre-existing build-blocking syntax error in the RegExp constructor. Verified with pnpm test:run and code analysis. Co-authored-by: ruhdevops <203426218+ruhdevops@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
|
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
ytstudio | 86ae2f7 | May 15 2026, 04:20 AM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
ytstudio | 86ae2f7 | May 15 2026, 04:20 AM |
This change improves the UX of the search functionality by: - Refactoring the "No results found" empty state to use consistent design-system classes (`btn btn-secondary`). - Removing inline 'onclick' handlers in favor of robust event delegation. - Ensuring focus is returned to the search input after clearing results for better keyboard accessibility. - Adding 'aria-hidden' to decorative icons in the empty state. - Fixing a build-blocking syntax error in the RegExp constructor. Verified with pnpm test:run (100% pass). Co-authored-by: ruhdevops <203426218+ruhdevops@users.noreply.github.com>
This change improves the UX of the search functionality by: - Refactoring the "No results found" empty state to use consistent design-system classes (`btn btn-secondary`). - Removing inline 'onclick' handlers in favor of robust event delegation. - Ensuring focus is returned to the search input after clearing results for better keyboard accessibility. - Adding 'aria-hidden' to decorative icons in the empty state. - Fixing a pre-existing build-blocking syntax error in the RegExp constructor. Verified with pnpm test:run (100% pass). Co-authored-by: ruhdevops <203426218+ruhdevops@users.noreply.github.com>
This change improves the UX of the search functionality by: - Refactoring the "No results found" empty state to use consistent design-system classes (`btn btn-secondary`). - Removing inline 'onclick' handlers in favor of robust event delegation. - Ensuring focus is returned to the search input after clearing results for better keyboard accessibility. - Adding 'aria-hidden' to decorative icons in the empty state. - Fixing a pre-existing build-blocking syntax error in the RegExp constructor. Verified with pnpm test:run (100% pass). Co-authored-by: ruhdevops <203426218+ruhdevops@users.noreply.github.com>
1 participant
Refactored the search empty state in
js/app.jsto use standard design system classes (btn btn-secondary) and unique IDs for action buttons. Moved the clear-search logic from an inlineonclickhandler to a delegated event listener inbindEvents, which now handles clearing the search, refocusing the input, and updating the application state. Addedaria-hiddento the magnifying glass icon for improved screen reader experience. Additionally, resolved a pre-existing syntax error injs/app.jswhere a template literal inside anew RegExp()constructor was causing production build failures.PR created automatically by Jules for task 13774829082900392125 started by @ruhdevops