Repository navigation
fix(library): preserve public file links after S3 migration - #57
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching a public library from disk to S3 currently makes existing
/files/...media URLs return 404. Preserve those URLs by checking that the asset is available and redirecting to a five-minute signed S3 URL. Cache redirects for only one minute so an expired signature is never kept as an immutable media response.Unknown and withdrawn assets retain their 404/410 responses. Private S3 libraries continue to require the authenticated file endpoint. This allows staging storage to move to a private R2 bucket without rewriting existing book and image URLs.
Validation: library-server suite passed (117 tests, 1 skipped), including three new migration regressions; typecheck and lint passed. The full suite used a 30-second test timeout while CPU rendering ran concurrently.