Skip to content

update loot-console-logger#11136

Merged
Alexsuperfly merged 4 commits intorunelite:masterfrom
emerycp:loot-console-logger
Apr 8, 2026
Merged

update loot-console-logger#11136
Alexsuperfly merged 4 commits intorunelite:masterfrom
emerycp:loot-console-logger

Conversation

@emerycp
Copy link
Copy Markdown
Contributor

@emerycp emerycp commented Mar 19, 2026

  • added a new sidebar that lets you log like a feed, apply filters, and track via a summary.
  • updated the base code for logging in the console.
  • added more options in the settings for greater customization.
  • rewrote a more comprehensive README.

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Mar 19, 2026

Plugin repository has changed

loot-console-logger: d09ce0e13c84bd5679e5bedd52ec368976bf2c0f..d0ce0f5ff91110b2cbe8ec0ceb9d439c0ba5802e

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Mar 19, 2026

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@Felanbird
Copy link
Copy Markdown
Contributor

You're submitting the entire plugin-hub in this PR, please don't do that.

@Felanbird Felanbird added the waiting for author waiting for the pr author to make changes or respond to questions label Mar 19, 2026
- mistakenly rebased on the plugin-hub. created a new repo to start fresh.
@runelite-github-app runelite-github-app Bot removed waiting for author waiting for the pr author to make changes or respond to questions size-xl labels Mar 19, 2026
@emerycp
Copy link
Copy Markdown
Contributor Author

emerycp commented Mar 19, 2026

You're submitting the entire plugin-hub in this PR, please don't do that.

Yep, mistake on my end, sorry!
I mistakenly rebased on plugin-hub. I created a new repo, and I updated the commit hash to the latest commit on the new repo. It should be good now.

@riktenx
Copy link
Copy Markdown
Member

riktenx commented Mar 25, 2026

the commit hashes should match

@riktenx
Copy link
Copy Markdown
Member

riktenx commented Mar 25, 2026

you should be forking the original thing or mirror-pushing the branch to another repo if you know how to do that basically

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Mar 25, 2026
@emerycp
Copy link
Copy Markdown
Contributor Author

emerycp commented Mar 26, 2026

you should be forking the original thing or mirror-pushing the branch to another repo if you know how to do that basically

I renamed the old repo to loot-console-logger-old and created a new one with the original name, loot-console-logger, and a freshly forked copy of example-plugin, then mirrored all my changes to fix my mistake of rebasing on plugin-hub.

I think the RuneLite GitHub bot didn't count it as a change and that's why the hashes don't match. The commit hash is set to the latest commit of the newest repo but the bot's comment has an old hash pointing to the old repo. Should I open another PR, and close this one ?

@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Mar 26, 2026
@Alexsuperfly
Copy link
Copy Markdown
Contributor

rewriting the history like you did means we have to review this as an entirely new plugin again, you will need to restore the original history if you want this to be reviewed as a plugin update.

@Alexsuperfly Alexsuperfly added the waiting for author waiting for the pr author to make changes or respond to questions label Apr 1, 2026
@runelite-github-app runelite-github-app Bot added size-l and removed waiting for author waiting for the pr author to make changes or respond to questions labels Apr 1, 2026
@Alexsuperfly Alexsuperfly merged commit 0542f39 into runelite:master Apr 8, 2026
2 of 3 checks passed
Infinitay pushed a commit to Infinitay/plugin-hub that referenced this pull request Apr 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants